Add test for parsing complex enum parameters in MCP #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for JVM93 new problems were found
@@ Code coverage @@
+ 50% total lines covered
5769 lines analyzed, 2924 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Detected 116 dependenciesThird-party software listThis page lists the third-party software dependencies used in koog-agents
Contact Qodana teamContact us at [email protected]
|
tiginamaria
approved these changes
Jun 20, 2025
There was a problem hiding this comment.
Thank you for noticing this!
After investigation, it turned out that arg type should support any type of Json Schema including mixed json https://json-schema.org/understanding-json-schema/reference/enum?utm_source=chatgpt.com#extended-example:-accepting-multiple-data-types where we can include values of different type to enums list
{
"properties": {
"color": {
"enum": ["red", "amber", "green", null, 42]
}
}
}
tiginamaria
reviewed
Jun 20, 2025
agents/agents-mcp/src/jvmTest/kotlin/ai/koog/agents/mcp/DefaultMcpToolDescriptorParserTest.kt
Outdated
Show resolved
Hide resolved
aozherelyeva
force-pushed
the
zarechneva/mcp-complex-enum-test
branch
from
29be379 to
315eb01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test covering the complex enum parameters structure in MCP.
Should be enabled when #307 is fixed.
Type of the change
Checklist for all pull requests
developas the base branchAdditional steps for pull requests adding a new feature