[prompt] [integration-tests] Fix intput/output token counts for OpenAILLMClient #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to integration tests
aozherelyeva
approved these changes
Jun 30, 2025
|
Do these changes with |
Qodana for JVM133 new problems were found
@@ Code coverage @@
+ 53% total lines covered
5905 lines analyzed, 3168 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Detected 116 dependenciesThird-party software listThis page lists the third-party software dependencies used in koog-agents
Contact Qodana teamContact us at [email protected]
|
tiginamaria
approved these changes
Jun 30, 2025
...penai-client/src/commonMain/kotlin/ai/koog/prompt/executor/clients/openai/OpenAILLMClient.kt
Outdated
Show resolved
Hide resolved
This does not affect current approaches, they would still work, but it's still a good idea to mention this option there too, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix input/output tokens in
OpenAILLMClient. Add check for tokens count in integration tests. Also applied credentials resolver plugin in integration tests (just like in examples) to make running the tests and passing API keys a bit easier when developing.Fixes #368