History compression fix #394
Merged
+440
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tags to prevent unintended response patterns.
…d structured responses.
…rieveFactsFromHistory` logic.
…13880-improve-compression-history-2
Qodana for JVM178 new problems were found
@@ Code coverage @@
+ 56% total lines covered
6090 lines analyzed, 3447 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Detected 204 dependenciesThird-party software listThis page lists the third-party software dependencies used in koog-agents
Contact Qodana teamContact us at [email protected]
|
kpavlov
reviewed
Jul 5, 2025
| append("<${MemoryPrompts.historyWrapperTag}>\n") | ||
| oldPrompt.messages.forEach { message -> | ||
| when (message) { | ||
| is Message.System -> append("<user>\n${message.content}\n</user>\n") |
There was a problem hiding this comment.
QQ: Is the "system" message converted to a "user" message intentionally? Do we ever need to preserve a system message in the history snippett?
There was a problem hiding this comment.
Yes, it was done intentionally to reduce its influence to LLM behavior. But we decided to keep it as user, because it may contain important context and task details to consider.
There was a problem hiding this comment.
@kpavlov without this change, LLM was following the system message instructions instead of summarization
Ololoshechkin
approved these changes
Jul 5, 2025
There was a problem hiding this comment.
Thank you so much @denis-domanskii for working on this and for finding this problem!
tiginamaria
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing fact-retrieval strategy in history compression doesn't work because of LLM hallucination issues (tldr: after ~200 tool call messages and with old System message, LLM ignores "now summarize previous history" request and continues to do the original task).
To fix the issue, several changes were made:
Also I performed manual checks - looks fine.
Type of the change
Checklist for all pull requests
developas the base branchAdditional steps for pull requests adding a new feature