JBAI-14524. Fix Open Telemetry attributes conversion logic #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update extension function for Span attributes; - Add tests to verify span attributes conversion; - Cleanup code for Open Telemetry.
EugeneTheDev
approved these changes
Jul 6, 2025
sproshev
approved these changes
Jul 7, 2025
...entelemetry/src/jvmMain/kotlin/ai/koog/agents/features/opentelemetry/attribute/attributes.kt
Outdated
Show resolved
Hide resolved
- Fixed comments from CR; - Fix tests; - Add event body field and logic to convert them into attributes; - Add more tests for new entities.
|
@sproshev, @EugeneTheDev , thank you for your review. I've found that some tests for OT start to failed after my change. I've made a couple of changes in spans that are we create to fix the problem. The issue is related to event body fields. According to Semantic convention, body fields should have a defined structure. However, this is not supported inside SDK. I've introduced the support inside the feature and add a simple conversion from event body field into an attribute. All body fields are added as attributes for now. |
Qodana for JVM240 new problems were found
@@ Code coverage @@
+ 59% total lines covered
6588 lines analyzed, 3914 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
sproshev
requested changes
Jul 7, 2025
...entelemetry/src/jvmMain/kotlin/ai/koog/agents/features/opentelemetry/attribute/attributes.kt
Outdated
Show resolved
Hide resolved
...entelemetry/src/jvmMain/kotlin/ai/koog/agents/features/opentelemetry/attribute/attributes.kt
Outdated
Show resolved
Hide resolved
...entelemetry/src/jvmMain/kotlin/ai/koog/agents/features/opentelemetry/attribute/attributes.kt
Outdated
Show resolved
Hide resolved
...entelemetry/src/jvmMain/kotlin/ai/koog/agents/features/opentelemetry/event/EventBodyField.kt
Show resolved
Hide resolved
sdubov
force-pushed
the
sdubov/JBAI-14524-fixes-types
branch
from
c400ac5 to
ea5f177
Compare
- Convert event field to a single attribute; - Fix service name and service version; - Update tests; - Update README.md according to xthe latest changes.
sdubov
force-pushed
the
sdubov/JBAI-14524-fixes-types
branch
from
ea5f177 to
d7a4dd8
Compare
12 tasks
sproshev
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of the change
Checklist for all pull requests
developas the base branchAdditional steps for pull requests adding a new feature