🐛 Fix Anthropic json schema validation error #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue with the Anthropic API integration where complex nested tool structures were causing JSON schema validation errors. The Anthropic API requires JSON schemas to comply with JSON Schema draft 2020-12, but our current implementation was generating invalid nested structures.
EugeneTheDev
approved these changes
Jul 18, 2025
| @@ -0,0 +1,241 @@ | |||
| package ai.koog.agents.example.anthropic | |||
There was a problem hiding this comment.
Please remove this file, it's not needed here as it was used only to reproduce the error. I see the same logic already being added as an integration test, which is appropriate place for such verifications.
There was a problem hiding this comment.
Yes that was definitely the plan, just kept it in case it helped for the review.
skarpovdev
reviewed
Jul 18, 2025
| import kotlin.test.assertTrue | ||
|
|
||
| /** | ||
| * Integration test for verifying the fix for the Anthropic API JSON schema validation error |
There was a problem hiding this comment.
Let's remove the mention of the fix and just describe what case the test verifies
| * Integration test for verifying the fix for the Anthropic API JSON schema validation error | ||
| * when using complex nested structures in tool parameters. | ||
| * | ||
| * The issue was in the AnthropicLLMClient.kt file, specifically in the getTypeMapForParameter() function |
There was a problem hiding this comment.
Same here, it just describes what wasn't working.
| * The issue was in the AnthropicLLMClient.kt file, specifically in the getTypeMapForParameter() function | ||
| * that converts ToolDescriptor objects to JSON schemas for the Anthropic API. | ||
| * | ||
| * The problem was that when processing ToolParameterType.Object, the function created invalid nested structures |
| * "type": {"type": "string"} // Invalid nesting | ||
| * } | ||
| * | ||
| * This test verifies that the fix works by creating an agent with the Anthropic API and a tool |
Comment on lines
+63
to
+65
| /** | ||
| * Address type enum. | ||
| */ |
There was a problem hiding this comment.
I'd remove the comment. It appears self-explanatory.
Comment on lines
+71
to
+73
| /** | ||
| * An address with multiple fields. | ||
| */ |
| ) | ||
|
|
||
| /** | ||
| * A user profile with nested structures. |
| /** | ||
| * A complex nested tool that demonstrates the JSON schema validation error. | ||
| * This tool has parameters with complex nested structures that would trigger | ||
| * the error in the Anthropic API before the fix. |
There was a problem hiding this comment.
another mention of the fix
Comment on lines
+189
to
+196
| * Test that verifies the fix for the Anthropic API JSON schema validation error | ||
| * when using complex nested structures in tool parameters. | ||
| * | ||
| * Before the fix, this test would fail with an error like: | ||
| * "tools.0.custom.input_schema: JSON schema is invalid. It must match JSON Schema draft 2020-12" | ||
| * | ||
| * After the fix, the test should pass, demonstrating that the Anthropic API | ||
| * can now correctly handle complex nested structures in tool parameters. |
There was a problem hiding this comment.
another mention of the fix and the problem that was once there
slawa4s
pushed a commit
that referenced
this pull request
Jul 31, 2025
Co-authored-by: Bruno Lannoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Anthropic API JSON Schema Validation Error
This PR fixes an issue with the Anthropic API integration where complex nested tool structures were causing JSON schema validation errors. The Anthropic API requires JSON schemas to comply with JSON Schema draft 2020-12, but our current implementation was generating invalid nested structures.
The fix modifies the
getTypeMapForParameter()function inAnthropicLLMClient.ktto correctly generate compliant schemas by:requiredfield for object schemas when applicableadditionalProperties: falsefor stricter validationI first created an example to reproduce the issue (
AnthropicSchemaErrorAgent.kt) most likely that one should be deleted before merging and an integration test (AnthropicSchemaValidationIntegrationTest.kt) that hopefully can be kept.Most of these changes are generated in collaboration with Junie, so certainly could use a thorough review.
Type of the change
Checklist for all pull requests
developas the base branchAdditional steps for pull requests adding a new feature