Add support for excluding properties in JSON schema generation #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
Checks are all green (except qodana as usual since I don't have the token on my fork), it's ready for review! |
|
Yeah 🥳 |
kpavlov
approved these changes
Sep 2, 2025
kpavlov
approved these changes
Sep 2, 2025
karloti
pushed a commit
to karloti/koog
that referenced
this pull request
Sep 2, 2025
…ains#638) Fixes JetBrains#377 Changes are the same as JetBrains#378, it's just the updated version after the refactor of JetBrains#443 Proposed changes: Add an `excludedProperties` parameter like this: ```kotlin simpleSchemaGenerator.generate( "TestClass", serializer<TestClass>(), descriptionOverrides = emptyMap(), excludedProperties = setOf("TestClass.someProperty") ) ``` --- #### Type of the change - [x] New feature - [ ] Bug fix - [ ] Documentation fix #### Checklist for all pull requests - [x] The pull request has a description of the proposed change - [x] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [x] Tests for the changes have been added - [x] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [x] An issue describing the proposed change exists - [x] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #377
Changes are the same as #378, it's just the updated version after the refactor of #443
Proposed changes:
Add an
excludedPropertiesparameter like this:simpleSchemaGenerator.generate( "TestClass", serializer<TestClass>(), descriptionOverrides = emptyMap(), excludedProperties = setOf("TestClass.someProperty") )Type of the change
Checklist for all pull requests
developas the base branchAdditional steps for pull requests adding a new feature