Skip to content

Conversation

Ololoshechkin
Copy link
Collaborator

@Ololoshechkin Ololoshechkin commented Aug 25, 2025

Motivation and Context

Breaking Changes


Type of the changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tests improvement
  • Refactoring

Checklist

  • The pull request has a description of the proposed change
  • I read the Contributing Guidelines before opening the pull request
  • The pull request uses develop as the base branch
  • Tests for the changes have been added
  • All new and existing tests passed
Additional steps for pull requests adding a new feature
  • An issue describing the proposed change exists
  • The pull request includes a link to the issue
  • The change was discussed and approved in the issue
  • Docs have been added / updated

Copy link
Contributor

@aozherelyeva aozherelyeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you!

Copy link

github-actions bot commented Aug 25, 2025

Qodana for JVM

591 new problems were found

Inspection name Severity Problems
Check Kotlin and Java source code coverage 🔶 Warning 554
Missing KDoc for public API declaration 🔶 Warning 30
Vulnerable imported dependency 🔶 Warning 6
String concatenation that can be converted to string template ◽️ Notice 1
@@ Code coverage @@
+ 70% total lines covered
9325 lines analyzed, 6579 lines covered
# Calculated according to the filters of your coverage tool

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link
Collaborator

@antoniibelyshev antoniibelyshev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I would suggest dropping a warning message in case of an empty parts (and empty content too).

AFAIU, missing parts field is not a good sign: for example, it could result in an empty list of responses, which is not a supposed behavior.

@Ololoshechkin
Copy link
Collaborator Author

@antoniibelyshev thanks! I'll add a warning.
Indeed, it's not a supposed behavior, but apparently, that's what Gemini Flash 2.5 and Pro 2.5 do from time to time (and not on all accounts). There's a thread about that -- https://discuss.ai.google.dev/t/gemini-2-5-pro-with-empty-response-text/81175/219 -- the first problem happened in April, and the last question was from 4 hour ago -- and still not fixed.

So, on our end we can only support this and put a warning

@Ololoshechkin Ololoshechkin merged commit d466bdc into develop Aug 25, 2025
8 checks passed
@Ololoshechkin Ololoshechkin deleted the vbr/google-parts branch August 25, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants