feat: add connection confirm dialog components #2634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellacosse
commented
Sep 15, 2025
| @@ -75,6 +75,14 @@ | |||
| "description": "The title of a message to the user that tells them Outline will keep connected unless explicitly told to disconnect. Outline is the product name and can be found in the translation glossary.", | |||
| "message": "Stay protected, always" | |||
| }, | |||
| "basic_access_content": { | |||
| "description": "The body text of a dialog box explaining what 'Basic Access' means for a server connection.", | |||
| "message": "Outline Basic Access is an alternative way to connect to the open internet. It offers limited protection of your internet traffic. This approach will make it harder for outside observers to see what you connect to online, without the use of a VPN (proxy) server.<br><br>This feature may help you connect to the open internet if you do not have a traditional Outline VPN access key, or if your VPN access key is not successfully connecting. <a src='TODO'>Learn more</a>" | |||
There was a problem hiding this comment.
What is the link here?
There was a problem hiding this comment.
Maybe use Learn more (TBD) to remind us updating the link in the UI?
jyyi1
reviewed
Sep 15, 2025
| @@ -75,6 +75,14 @@ | |||
| "description": "The title of a message to the user that tells them Outline will keep connected unless explicitly told to disconnect. Outline is the product name and can be found in the translation glossary.", | |||
| "message": "Stay protected, always" | |||
| }, | |||
| "basic_access_content": { | |||
| "description": "The body text of a dialog box explaining what 'Basic Access' means for a server connection.", | |||
| "message": "Outline Basic Access is an alternative way to connect to the open internet. It offers limited protection of your internet traffic. This approach will make it harder for outside observers to see what you connect to online, without the use of a VPN (proxy) server.<br><br>This feature may help you connect to the open internet if you do not have a traditional Outline VPN access key, or if your VPN access key is not successfully connecting. <a src='TODO'>Learn more</a>" | |||
There was a problem hiding this comment.
Maybe use Learn more (TBD) to remind us updating the link in the UI?
daniellacosse
commented
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces new dialogs and supporting infrastructure for confirming connections with limited protection modes, such as Basic Access, Proxyless, and Split Tunneling.
I also converted
server_info_dialogto rems for users who might have set a larger system text size (like me).