Skip to content

Conversation

matbesancon
Copy link
Contributor

Changed name: there was a weird mixup of the object name with the type passed to Ptr

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 89.93% // Head: 89.93% // No change to project coverage 👍

Coverage data is based on head (244f02c) compared to base (6005530).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files           1        1           
  Lines         328      328           
=======================================
  Hits          295      295           
  Misses         33       33           
Impacted Files Coverage Δ
src/BasicLU.jl 89.93% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amontoison
Copy link
Member

We should probably remove all Ptr{basiclu_object_type} and use Ptr{Cvoid} directly.

@matbesancon
Copy link
Contributor Author

no strong opinion, in SCIP.jl I found it more readable to mimick the type of the header file

@matbesancon
Copy link
Contributor Author

Otherwise there are signatures with Ptr{Cvoid} and Ptr{Cint} all over the place

@matbesancon
Copy link
Contributor Author

done

@amontoison amontoison merged commit 79c62f2 into JuliaSmoothOptimizers:main Dec 8, 2022
@amontoison
Copy link
Member

Thanks!

@matbesancon matbesancon deleted the refactor branch December 8, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants