Skip to content

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Jul 24, 2025

What are the changes introduced in this pull request?

This reverts the change that had been done in 40a4420 to accomodate for a pinned version of react-bootstrap. The pin is gone now and so the snapshots need to match the "original" again.

Considerations taken when implementing this change?

<insert colorful language about JS>

What are the testing steps for this pull request?

CI is sufficient

Summary by Sourcery

Restore original React component snapshots after removing react-bootstrap version pin and update CI workflow to target the pull request head

CI:

  • Change foreman_version in react_tests workflow to refs/pull/10624/head

Tests:

  • Update ContentDetails and SubscriptionDetails snapshots to match current component output

Copy link

sourcery-ai bot commented Jul 24, 2025

Reviewer's Guide

This PR removes the temporary react-bootstrap pin by undoing the earlier workaround commit, regenerates the JSX snapshots to match the original component output, and updates the CI workflow to point at the current pull request branch.

File-Level Changes

Change Details Files
Revert react-bootstrap version fix and restore snapshots
  • Removed the workaround commit effects
  • Regenerated snapshots for ContentDetails and SubscriptionDetails to match original markup
webpack/components/Content/Details/__tests__/__snapshots__/ContentDetails.test.js.snap
webpack/scenes/Subscriptions/Details/__tests__/__snapshots__/SubscriptionDetails.test.js.snap
Point CI workflow to this PR branch
  • Changed foreman_version from develop to refs/pull/10624/head
.github/workflows/react_tests.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @evgeni - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant