Skip to content

Conversation

m-bucher
Copy link
Contributor

@m-bucher m-bucher commented Feb 4, 2019

Depends on #7418
Add support for Debian/Ubuntu errata using external service, which:

  1. parses Debian Security Announcements (DSA) and Ubuntu Security Notices (USN): https://github.com/ATIX-AG/errata_parser

  2. serves the resulting errata: https://github.com/ATIX-AG/errata_server

@theforeman-bot
Copy link

Do not merge! This patch has not been tested yet.

Can an existing organization member please verify this patch?

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • a7e84d6 must be in the format fixes #redmine_number - brief description
  • 0cefc50 must be in the format fixes #redmine_number - brief description
  • 5c63609 must be in the format fixes #redmine_number - brief description
  • 6d04780 must be in the format fixes #redmine_number - brief description
  • 66b4138 must be in the format fixes #redmine_number - brief description
  • 9e2d4a1 must be in the format fixes #redmine_number - brief description
  • c9b8b94 must be in the format fixes #redmine_number - brief description
  • 524589c must be in the format fixes #redmine_number - brief description
  • length of the first commit message line for 524589c exceeds 65 characters
  • 79da3ce must be in the format fixes #redmine_number - brief description
  • d2ec936 must be in the format fixes #redmine_number - brief description
  • 210d749 must be in the format fixes #redmine_number - brief description
  • 403dddd must be in the format fixes #redmine_number - brief description
  • 9333543 must be in the format fixes #redmine_number - brief description
  • ce61601 must be in the format fixes #redmine_number - brief description
  • 56f5391 must be in the format fixes #redmine_number - brief description
  • b22016a must be in the format fixes #redmine_number - brief description
  • d0c1e32 must be in the format fixes #redmine_number - brief description
  • 53caf97 must be in the format fixes #redmine_number - brief description
  • 44635fd must be in the format fixes #redmine_number - brief description
  • dee8f32 must be in the format fixes #redmine_number - brief description
  • 0cc7ce9 must be in the format fixes #redmine_number - brief description
  • 1220020 must be in the format fixes #redmine_number - brief description
  • 3020f82 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • a7e84d6 must be in the format fixes #redmine_number - brief description
  • 0cefc50 must be in the format fixes #redmine_number - brief description
  • 5c63609 must be in the format fixes #redmine_number - brief description
  • 6d04780 must be in the format fixes #redmine_number - brief description
  • 66b4138 must be in the format fixes #redmine_number - brief description
  • 9e2d4a1 must be in the format fixes #redmine_number - brief description
  • c9b8b94 must be in the format fixes #redmine_number - brief description
  • 524589c must be in the format fixes #redmine_number - brief description
  • length of the first commit message line for 524589c exceeds 65 characters
  • 79da3ce must be in the format fixes #redmine_number - brief description
  • d2ec936 must be in the format fixes #redmine_number - brief description
  • 210d749 must be in the format fixes #redmine_number - brief description
  • 403dddd must be in the format fixes #redmine_number - brief description
  • 9333543 must be in the format fixes #redmine_number - brief description
  • ce61601 must be in the format fixes #redmine_number - brief description
  • 56f5391 must be in the format fixes #redmine_number - brief description
  • b22016a must be in the format fixes #redmine_number - brief description
  • d0c1e32 must be in the format fixes #redmine_number - brief description
  • 53caf97 must be in the format fixes #redmine_number - brief description
  • 44635fd must be in the format fixes #redmine_number - brief description
  • dee8f32 must be in the format fixes #redmine_number - brief description
  • 0cc7ce9 must be in the format fixes #redmine_number - brief description
  • 1220020 must be in the format fixes #redmine_number - brief description
  • 3020f82 must be in the format fixes #redmine_number - brief description
  • 470ffa3 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@tbrisker
Copy link
Member

tbrisker commented Feb 6, 2019

[test katello]

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • a7e84d6 must be in the format fixes #redmine_number - brief description
  • 0cefc50 must be in the format fixes #redmine_number - brief description
  • 5c63609 must be in the format fixes #redmine_number - brief description
  • 6d04780 must be in the format fixes #redmine_number - brief description
  • 66b4138 must be in the format fixes #redmine_number - brief description
  • 9e2d4a1 must be in the format fixes #redmine_number - brief description
  • c9b8b94 must be in the format fixes #redmine_number - brief description
  • 524589c must be in the format fixes #redmine_number - brief description
  • length of the first commit message line for 524589c exceeds 65 characters
  • 79da3ce must be in the format fixes #redmine_number - brief description
  • d2ec936 must be in the format fixes #redmine_number - brief description
  • 210d749 must be in the format fixes #redmine_number - brief description
  • 403dddd must be in the format fixes #redmine_number - brief description
  • 9333543 must be in the format fixes #redmine_number - brief description
  • ce61601 must be in the format fixes #redmine_number - brief description
  • 56f5391 must be in the format fixes #redmine_number - brief description
  • b22016a must be in the format fixes #redmine_number - brief description
  • d0c1e32 must be in the format fixes #redmine_number - brief description
  • 53caf97 must be in the format fixes #redmine_number - brief description
  • 44635fd must be in the format fixes #redmine_number - brief description
  • dee8f32 must be in the format fixes #redmine_number - brief description
  • 0cc7ce9 must be in the format fixes #redmine_number - brief description
  • 1220020 must be in the format fixes #redmine_number - brief description
  • 3020f82 must be in the format fixes #redmine_number - brief description
  • 470ffa3 must be in the format fixes #redmine_number - brief description
  • e63f390 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@m-bucher
Copy link
Contributor Author

m-bucher commented Feb 8, 2019

Forgot to mention that this depends on #7418, which is also the reason for some test-failures:

NameError: uninitialized constant Katello::InstalledDeb

Not sure though, if it makes sense to rebase this PR on the other branch(, if #7418 is on the brink of being merged 😉 )

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • a7e84d6 must be in the format fixes #redmine_number - brief description
  • 0cefc50 must be in the format fixes #redmine_number - brief description
  • 5c63609 must be in the format fixes #redmine_number - brief description
  • 6d04780 must be in the format fixes #redmine_number - brief description
  • 66b4138 must be in the format fixes #redmine_number - brief description
  • 9e2d4a1 must be in the format fixes #redmine_number - brief description
  • c9b8b94 must be in the format fixes #redmine_number - brief description
  • 524589c must be in the format fixes #redmine_number - brief description
  • length of the first commit message line for 524589c exceeds 65 characters
  • 79da3ce must be in the format fixes #redmine_number - brief description
  • d2ec936 must be in the format fixes #redmine_number - brief description
  • 210d749 must be in the format fixes #redmine_number - brief description
  • 403dddd must be in the format fixes #redmine_number - brief description
  • 9333543 must be in the format fixes #redmine_number - brief description
  • ce61601 must be in the format fixes #redmine_number - brief description
  • 56f5391 must be in the format fixes #redmine_number - brief description
  • b22016a must be in the format fixes #redmine_number - brief description
  • d0c1e32 must be in the format fixes #redmine_number - brief description
  • 53caf97 must be in the format fixes #redmine_number - brief description
  • 44635fd must be in the format fixes #redmine_number - brief description
  • dee8f32 must be in the format fixes #redmine_number - brief description
  • 0cc7ce9 must be in the format fixes #redmine_number - brief description
  • 1220020 must be in the format fixes #redmine_number - brief description
  • 3020f82 must be in the format fixes #redmine_number - brief description
  • 470ffa3 must be in the format fixes #redmine_number - brief description
  • e63f390 must be in the format fixes #redmine_number - brief description
  • c71e832 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@theforeman-bot
Copy link

Can one of the admins verify this patch?

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • a7e84d6 must be in the format fixes #redmine_number - brief description
  • 0cefc50 must be in the format fixes #redmine_number - brief description
  • 5c63609 must be in the format fixes #redmine_number - brief description
  • 6d04780 must be in the format fixes #redmine_number - brief description
  • 66b4138 must be in the format fixes #redmine_number - brief description
  • 9e2d4a1 must be in the format fixes #redmine_number - brief description
  • c9b8b94 must be in the format fixes #redmine_number - brief description
  • 524589c must be in the format fixes #redmine_number - brief description
  • length of the first commit message line for 524589c exceeds 65 characters
  • 79da3ce must be in the format fixes #redmine_number - brief description
  • d2ec936 must be in the format fixes #redmine_number - brief description
  • 210d749 must be in the format fixes #redmine_number - brief description
  • 403dddd must be in the format fixes #redmine_number - brief description
  • 9333543 must be in the format fixes #redmine_number - brief description
  • ce61601 must be in the format fixes #redmine_number - brief description
  • 56f5391 must be in the format fixes #redmine_number - brief description
  • b22016a must be in the format fixes #redmine_number - brief description
  • d0c1e32 must be in the format fixes #redmine_number - brief description
  • 53caf97 must be in the format fixes #redmine_number - brief description
  • 44635fd must be in the format fixes #redmine_number - brief description
  • dee8f32 must be in the format fixes #redmine_number - brief description
  • 0cc7ce9 must be in the format fixes #redmine_number - brief description
  • 1220020 must be in the format fixes #redmine_number - brief description
  • 3020f82 must be in the format fixes #redmine_number - brief description
  • 470ffa3 must be in the format fixes #redmine_number - brief description
  • e63f390 must be in the format fixes #redmine_number - brief description
  • c71e832 must be in the format fixes #redmine_number - brief description
  • 594b90a must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@tbrisker
Copy link
Member

ok to test

@tbrisker
Copy link
Member

@m-bucher looks like this has some merge conflicts now. I've also invited you to the katello org so the bot will auto test your prs

@jturel
Copy link
Member

jturel commented Jun 18, 2019

@m-bucher now that #7418 is merged I'm prepared to test this in earnest once rebased. Looking forward to getting this merged in.

@jturel
Copy link
Member

jturel commented Jun 24, 2019

@m-bucher could you also provide steps on how to test this end-to-end ?

@bkearney
Copy link
Member

@m-bucher how goes this PR? Anything we can do to move it along?

@m-bucher
Copy link
Contributor Author

@jturel thanks for the offer.
We currently work on rebasing it to the latest upstream-katello.

For testing you need to configure a deb Repository for the Debian (or Ubuntu) security-updates repository, where you configure the URL of a running instance of our errata-parser-service in the Errata URL-field.

You may use our running instance at https://dep.atix.de/dep/api/v1/debian for Debian or https://dep.atix.de/dep/api/v1/ubuntu for Ubuntu, when testing.

For example:

Upstream URL: http://security.debian.org/debian-security/
Releases: stretch/updates
Errata URL: https://dep.atix.de/dep/api/v1/debian

@bkearney
Copy link
Member

bkearney commented Jul 2, 2019

Thanks @m-bucher, while the PR gets rebased is there anything we can do?

@theforeman-bot
Copy link

There were the following issues with the commit message:

  • a4190f5 must be in the format fixes #redmine_number - brief description
  • bb74b89 must be in the format fixes #redmine_number - brief description
  • f5108d0 must be in the format fixes #redmine_number - brief description
  • dd0ce30 must be in the format fixes #redmine_number - brief description
  • 091f489 must be in the format fixes #redmine_number - brief description
  • 34a97c0 must be in the format fixes #redmine_number - brief description
  • 1b6ff6d must be in the format fixes #redmine_number - brief description
  • d3522e4 must be in the format fixes #redmine_number - brief description
  • length of the first commit message line for d3522e4 exceeds 65 characters
  • 7ba7aaa must be in the format fixes #redmine_number - brief description
  • 862f506 must be in the format fixes #redmine_number - brief description
  • 3a4e894 must be in the format fixes #redmine_number - brief description
  • aa04975 must be in the format fixes #redmine_number - brief description
  • 1dd1042 must be in the format fixes #redmine_number - brief description
  • 743c46b must be in the format fixes #redmine_number - brief description
  • 42101ae must be in the format fixes #redmine_number - brief description
  • db519b9 must be in the format fixes #redmine_number - brief description
  • e02d52a must be in the format fixes #redmine_number - brief description
  • cda1de9 must be in the format fixes #redmine_number - brief description
  • 3464afe must be in the format fixes #redmine_number - brief description
  • a58b0c4 must be in the format fixes #redmine_number - brief description
  • 5decd91 must be in the format fixes #redmine_number - brief description
  • 9df709f must be in the format fixes #redmine_number - brief description
  • 418dd18 must be in the format fixes #redmine_number - brief description

If you don't have a ticket number, please create an issue in Redmine.

More guidelines are available in Coding Standards or on the Foreman wiki.


This message was auto-generated by Foreman's prprocessor

@shay1197
Copy link

shay1197 commented Sep 25, 2022

Hi guys,
Any updates on the PR?
@melcorr @m-bucher @jturel Jonathon

@martux69
Copy link

martux69 commented Nov 3, 2022

No activities on this important issue since 5 month?! @melcorr @lzap is it possible to get an actual state of this? Why is there no progress?

@shay1197
Copy link

shay1197 commented Nov 3, 2022

Fingers crossed that someone would promote this project

@melcorr
Copy link

melcorr commented Nov 8, 2022

Hey @martux69 @shay1197
I would love to see progress on this, but my ability to influence this work is quite limited.
I think the original poster of this and related PRs did not have the bandwidth to carry this to fruition.
@m-bucher is there any way for us to have status updates on this, or what you might need to move it along? I wonder if the issues were expanded upon, maybe there might be some smaller contributions that would help make this happen?

@quba42
Copy link
Contributor

quba42 commented Nov 29, 2022

I can give a brief update: We don't currently have the bandwidth for a major push on getting the Debain Errata feature in.

It is currently probably around third place on our internal priority list for major long term projects we really want to work on. The top priority (moving our downstream to EL8) is under heavy development and making progress. After that we will need to do a round of upgrading to latest Foreman/Katello releases, and then we may find the bandwidth for a major push on Debian Errata. Optimistically this could happen somewhere towards the end of the first quarter of the new year. Of course high priority short term issues can and often do insert themselves in this road map, so there are no promises. Personally, I will be pushing internally to put this on our agenda in the first half of 2023.

@shay1197
Copy link

Thank you on the update :)

@rossengeorgiev
Copy link

@quba42 would love to know if there a chance of the feature landing in Katello. You previous update sounded optimistic.

@quba42
Copy link
Contributor

quba42 commented May 3, 2023

Update: We have not yet started our push on this, but it is moving up the internal priority list with some of the things ahead of it now completed. A push in the first quarter of 2023 obviously did not happen. A push within the next two Months is possible but not very likely. Early in the second half of 2023 is realistic. As always this is not a promise. 😉

sbernhard pushed a commit to ATIX-AG/katello that referenced this pull request Sep 18, 2023
@shay1197
Copy link

shay1197 commented Oct 2, 2023

Hi,
@quba42 any new update??
I can see PR. :)

Co-Authored-by: Markus Bucher <[email protected]>
Co-Authored-by: Bernhard Suttner <[email protected]>
Co-Authored-by: Manisha Singhal <[email protected]>
@m-bucher m-bucher force-pushed the feature/debian_errata branch from 77f4257 to 76129c4 Compare January 30, 2024 15:35
sbernhard pushed a commit to ATIX-AG/katello that referenced this pull request Feb 29, 2024
Co-Authored-by: Markus Bucher <[email protected]>
Co-Authored-by: Bernhard Suttner <[email protected]>
Co-Authored-by: Manisha Singhal <[email protected]>

from Katello#7961
sbernhard pushed a commit to ATIX-AG/katello that referenced this pull request Mar 8, 2024
Co-Authored-by: Markus Bucher <[email protected]>
Co-Authored-by: Bernhard Suttner <[email protected]>
Co-Authored-by: Manisha Singhal <[email protected]>

from Katello#7961
@martux69
Copy link

Could someone post a status update for this issue? Perhaps is a final release date at the horizon?

@m-bucher
Copy link
Contributor Author

@martux69 unfortunately, I do not think it is on the horizon, yet. There are still some ToDos on the way.
The current state here should work fine with Katello-4.11.

There is a discussion to be had regarding the current workflow, with a separate parser and server, where Katello syncs the Errata from. The question being should we rather integrate the Parser into Katello or a local service on the Foreman/Katello server.

In the meantime I will have a look, if there are parts here that can already be merged separately, thus reducing the size of this PR.

@shay1197
Copy link

Hi again :)
Any new update??

@bazzybtec
Copy link

Does anyone know when this is likely to be merged to katello?

@shay1197
Copy link

Could someone post a status please :?

@dmgeurts-mm
Copy link

Thank you for working on this, how are things going?

@quba42
Copy link
Contributor

quba42 commented Jan 22, 2025

A lot of the key people familiar with this work will be meeting in person at CfgMgmtCamp in Ghent soon. @m-bucher and myself will be holding a talk that will cover the state of this work. There will also be space (workshop day) for a technical discussion between us and key Katello maintainers on what it would take to drive this work towards completion.

Once we have that plan there is still no guarantee it will be placed on our various road maps and have the necessary resources allocated to it, but I promise to post a next update after CfgMgmtCamp has concluded.

@dmgeurts-mm
Copy link

@quba42 Thank you for the update.

@martux69
Copy link

martux69 commented Feb 17, 2025

@quba42 The CfgMgmtCamp is over :-) It could be grateful if you can inform us about the planned road map for this feature.
Regarding to the post of @m-bucher from Apr 22, 2024 is perhaps for this any news (splitting the PR)? In a first step it would be very helpful to see a counter of the updateable packages in the content hosts view, regardless wether it is an errata/bug fix or not.

@quba42
Copy link
Contributor

quba42 commented Feb 18, 2025

Unfortunately I was out of commission these past two weeks, and was therefore unable to attend CfgMgmtCamp. However, my colleague @m-bucher tells me there were discussions on what is required of a Debian errata feature that could be merged to upstream Katello. Updating this very stale PR will be substantial work, but also we now believe there need to be some changes to the approach/architecture, with parts of the implementation currently in an external component (https://github.com/ATIX-AG/errata_parser) needing to move into Katello (or possibly Pulp). Given other priorities I have grown more pessimistic about the possibility of a major push on this within the foreseeable future. I will keep looking for opportunities to free up the needed time, but making any kind of promises of a firm road map at this point would be misleading. Apologies I don't have better news from our end.

@martux69
Copy link

Thank your for the information @quba42 .
Can you perhaps state something to the idea of splitting the PR? As mentioned at a first step it would be sufficient to see the counter of updateable deb packages, regardless of an integratio to the errata parser.
Could the PR #9886 be a solution for this?

@quba42
Copy link
Contributor

quba42 commented Feb 18, 2025

Could the PR #9886 be a solution for this?

As @melcorr posted on the other PR, I think that PR is unlikely to be revived. Even though I have sought to constrain expectations for any kind of rapid progress in the short term, I do believe our effort, currently represented by this PR is by far the most likely to eventually make it into the project. We will continue to transparently communicate any progress (or lack thereof), on our effort. Anything is possible in open source, but given everything I know, I think it unlikely a successful effort by anyone else will materialize.

@shay1197
Copy link

shay1197 commented Feb 25, 2025

Hi,
I don’t mean to be disrespectful, but I don’t understand why this has been open since 2019 until now when the ATIX team has had this feature for a long time ago. :
Is any change to push it?

@quba42
Copy link
Contributor

quba42 commented Feb 25, 2025

I don’t mean to be disrespectful, but I don’t understand why this has been open since 2019 until now when the ATIX team has had this feature for a long time ago.

There is nothing disrespectful about not understanding, I will try to explain:

  • Katello has a large, mature, and complex code base. Integrating major new features that touch on every aspect of the architecture is a huge task.
  • Achieving a working state of such a feature on a branch at one point in time is the easy part. In order to then get it merged into the main branch, we need at least all of the following:
    1. The community can feel reasonably confident they can maintain the working state within the main branch for ever.
    2. It will not break any existing functionality or disrupt the existing upstream development and release process excessively.
    3. Both contributors and community need to be in agreement on the general approach, architecture and requirements.
    4. Both contributors and community need to free up the time for multiple rounds of review and refinement within a single release cycle.

This is the hard part and it is as much an organizational effort, as it is a technical problem. All of this needs to come together while there are a thousand competing demands on everyone's time.

As an example: I think the need to prioritize Pulp 2 to 3 singularly delayed any serious effort on this PR by at least two years. If we had not worked on creating a pulp3_deb plugin (which no one else was willing to do), Katello would have been forced to drop the existing deb/APT content support, so that was not an option.

Based on my experience with the work we already did on Errata, as well as other recent major Katello features, I estimate that it will take something like two developers doing very little else for 6 months (that is just on the ATIX side) to get this PR over the finish line, maybe more. If you are willing to supply that (or if you think you can do it in an afternoon) we would happily help you do so (at least if we consider it a serious good faith effort). If not, we will be the ones to decide if and when we can free up the time.

In a nutshell, that is how it can happen for a PR like this to remain open for years. 😉
We remain committed to eventually getting it in. But I cannot say when that might be possible.

quba42 pushed a commit to ATIX-AG/katello that referenced this pull request Feb 27, 2025
Co-Authored-by: Markus Bucher <[email protected]>
Co-Authored-by: Bernhard Suttner <[email protected]>
Co-Authored-by: Manisha Singhal <[email protected]>

from Katello#7961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.