Align on pulp_content_url #9878
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Pulp content URLs should always respect what's exposed in the pulp_content_url setting. This includes the /pulp/content part. It does highlight a missing setting for pulp_ansible content. Again, Katello should not have to guess URLs but discover it from the infrastructure.
|
I agree that it would be best to rely on |
|
@ekohl Would you like us to close out this PR? We're doing a cleanup of the open requests in Katello this afternoon. |
|
@qcjames53 fundamentally I still think Katello should not assume |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
The Pulp content URLs should always respect what's exposed in the pulp_content_url setting. This includes the /pulp/content part.
It does highlight a missing setting for pulp_ansible content. Again, Katello should not have to guess URLs but discover it from the infrastructure.
Considerations taken when implementing this change?
It was extracted from #9413, but it's probably incomplete. Consider it a start of a discussion.
What are the testing steps for this pull request?
There should be no changes for the user in default setup. If the user does change the content URL, it should be properly reflected.