Skip to content

Conversation

rmitsch
Copy link
Collaborator

@rmitsch rmitsch commented Sep 18, 2025

Description

This PR enhances the job classification functionality and improves engine handling across the codebase. The changes include updates to the classification core logic, engine wrapper improvements, and pre-commit configuration updates.

Related Issues

-

Changes Made

  • Enhanced classification core functionality with improved job processing logic
  • Updated engine wrapper to better handle different engine types (dspy, glix, huggingface, instructor, langchain, ollama, outlines, vllm)
  • Improved engine import handling and error management
  • Updated pre-commit configuration and removed black from the setup
  • Added ty.toml configuration file
  • Updated pyproject.toml with new dependencies and configuration
  • Enhanced OCR preprocessing tasks (docling, marker)
  • Improved distillation import handling

Checklist

  • Tests have been extended to cover changes in functionality
  • Existing and new tests succeed
  • Documentation updated (if applicable)
  • Related issues linked

Screenshots/Examples (if applicable)

-

@rmitsch rmitsch self-assigned this Sep 18, 2025
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 96.55172% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
sieves/engines/vllm_.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   90.83%   91.16%   +0.32%     
==========================================
  Files          44       44              
  Lines        3013     3056      +43     
==========================================
+ Hits         2737     2786      +49     
+ Misses        276      270       -6     
Files with missing lines Coverage Δ
sieves/engines/dspy_.py 86.20% <100.00%> (+0.75%) ⬆️
sieves/engines/glix_.py 91.52% <100.00%> (+0.45%) ⬆️
sieves/engines/huggingface_.py 90.47% <100.00%> (+0.73%) ⬆️
sieves/engines/instructor_.py 94.44% <100.00%> (+3.26%) ⬆️
sieves/engines/langchain_.py 94.59% <100.00%> (+6.35%) ⬆️
sieves/engines/missing.py 86.36% <100.00%> (+2.15%) ⬆️
sieves/engines/ollama_.py 91.07% <100.00%> (+2.18%) ⬆️
sieves/engines/outlines_.py 92.10% <100.00%> (+0.43%) ⬆️
sieves/engines/wrapper.py 95.65% <100.00%> (+0.09%) ⬆️
sieves/tasks/predictive/classification/core.py 93.79% <100.00%> (+3.31%) ⬆️
... and 3 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rmitsch rmitsch merged commit 1a1fa09 into main Sep 18, 2025
3 checks passed
@rmitsch rmitsch deleted the feat/examples-jobs-classification branch September 18, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant