Skip to content

Conversation

ajinabraham
Copy link
Member

@ajinabraham ajinabraham commented Aug 30, 2025

Describe the Pull Request

Checklist for PR

  • Run MobSF unit tests and lint tox -e lint,test
  • Tested Working on Linux, Mac, Windows, and Docker
  • Add unit test for any new Web API (Refer: StaticAnalyzer/tests.py)
  • Make sure tests are passing on your PR MobSF tests

Additional Comments (if any)

DESCRIBE HERE

Copy link

👋 @ajinabraham
Thank you for sending this pull request ❤️.
Please make sure you have followed our contribution guidelines. We will review it as soon as possible

@ajinabraham ajinabraham marked this pull request as ready for review August 31, 2025 01:52
@ajinabraham ajinabraham requested a review from Copilot August 31, 2025 01:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses security vulnerabilities by fixing path traversal vulnerabilities and improving input validation throughout the MobSF codebase. The fixes enhance the is_safe_path function and implement better path traversal detection.

  • Enhanced path traversal detection with URL decoding and absolute path checks
  • Updated all is_safe_path function calls to include the raw filename parameter
  • Added AR-slip protection for archive extraction

Reviewed Changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
mobsf/MobSF/utils.py Enhanced is_path_traversal function with URL decoding and absolute path detection
mobsf/StaticAnalyzer/views/ios/views/view_source.py Updated is_safe_path call to include raw filename parameter
mobsf/StaticAnalyzer/views/android/views/view_source.py Updated is_safe_path call to include raw filename parameter
mobsf/StaticAnalyzer/views/android/xapk.py Updated multiple is_safe_path calls to include raw filename parameter
mobsf/StaticAnalyzer/views/common/shared_func.py Added AR-slip protection and updated is_safe_path calls
mobsf/StaticAnalyzer/forms.py Replaced inline path traversal check with is_path_traversal function
mobsf/MobSF/views/home.py Updated is_safe_path call and removed redundant check
mobsf/DynamicAnalyzer/views/common/frida/views.py Updated is_safe_path call to include raw filename parameter
mobsf/DynamicAnalyzer/views/common/device.py Consolidated path traversal checks into single is_safe_path call
mobsf/MobSF/init.py Version bump to 4.4.1
.github/SECURITY.md Added security advisories for fixed vulnerabilities

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ajinabraham ajinabraham changed the title [Security] Fix Vulnerabilities [Security] Fix Vulnerabilities Aug 2025 MobSFv4.4.1 Aug 31, 2025
@ajinabraham ajinabraham changed the title [Security] Fix Vulnerabilities Aug 2025 MobSFv4.4.1 [Security] Fix Vulnerabilities Aug 2025 MobSF v4.4.1 Aug 31, 2025
@ajinabraham ajinabraham merged commit 7f3bc08 into master Aug 31, 2025
12 checks passed
@ajinabraham ajinabraham deleted the Aug2025 branch August 31, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant