Fix RecordCodecs not maintaining field order #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightenom
approved these changes
Jun 23, 2025
Technici4n
approved these changes
Aug 23, 2025
pupnewfster
reviewed
Aug 23, 2025
pupnewfster
approved these changes
Aug 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue outlined in #101.
The issue is caused by
com.mojang.serialization.codecs.RecordCodecBuilder$Instance, specifically theMapEncodersprovided by the overiden methodslift1,ap2,ap3,ap4, the order of operations is incorrect which results in the fields of record codecs being incorrectly ordered.This is only true for the encoders, the decoding is done in the correct order.