Skip to content

Phase Folding Optimization for Value Semantics #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Phase Folding Optimization for Value Semantics #3398

wants to merge 21 commits into from

Conversation

atgeller
Copy link
Contributor

Description

A version of #3306 that works on the value semantics instead of the reference semantics.

Some todos:

  • Definitions are split across files, it would be better to combine them
  • We ultimately decided against outlining subcircuits into functions, so that will need to be disabled and tests updated.

atgeller added 21 commits June 27, 2025 18:03
@atgeller
Add pass to find subcircuits with phase polynomials
307c24c 
Signed-off-by: Adam Geller <[email protected]>
@atgeller
Formatting
b2ca805 
Signed-off-by: Adam Geller <[email protected]>
@atgeller
Split subcircuits into separate functions
9bdf5a6 
Signed-off-by: Adam Geller <[email protected]>
@atgeller
Remove debug code
4ef12aa 
Signed-off-by: Adam Geller <[email protected]>
@atgeller
A bit of cleanup on subcircuit logic
ba7e16b 
Signed-off-by: Adam Geller <[email protected]>
@atgeller
Initial working prototype of phase polynomial calculations and rotati…
986fcee 
…on merging

Signed-off-by: Adam Geller <[email protected]>
@atgeller
Make classical values arguments to subcircuit functions to allow non-…
7f110a9 
…constant rotation angles

Signed-off-by: Adam Geller <[email protected]>
@atgeller
Some cleanup
70b369b 
Signed-off-by: Adam Geller <[email protected]>
@atgeller
Remove incorrectly placed braces
69de2cc 
Signed-off-by: Adam Geller <[email protected]>
@atgeller
Add tests for circuit breaking ops in preprocessing
89277a5 
Signed-off-by: Adam Geller <[email protected]>
@atgeller
Don't run phase polynomial based rotation merging opt on illegal circ…
753bbb8 
…uits, instead of failing

Signed-off-by: Adam Geller <[email protected]>
@atgeller
Avoid some possible memory leaks
3fd0e65 
Signed-off-by: Adam Geller <[email protected]>
@atgeller
Track inversion when combining phases, handle swaps
5b39536 
Signed-off-by: Adam Geller <[email protected]>
@atgeller
Myriad fixes and improvements to work on phase_estimation example
70a3188 
Signed-off-by: Adam Geller <[email protected]>
@atgeller
Formatting
a794e09 
Signed-off-by: Adam Geller <[email protected]>
@atgeller
Various performance fixes
ecccaa8 
Signed-off-by: Adam Geller <[email protected]>
@atgeller
Update tests
523dd81 
Signed-off-by: Adam Geller <[email protected]>
@atgeller
Update tests
a0fa4c7 
Signed-off-by: Adam Geller <[email protected]>
@atgeller
Add opt pipeline and test using CircuitCheck
047fc6f 
Signed-off-by: Adam Geller <[email protected]>
@atgeller
Fix bug in sort function
1746f47 
Signed-off-by: Adam Geller <[email protected]>
@atgeller
Add preliminary code to detect phase invariant loops
8c0d580 
Signed-off-by: Adam Geller <[email protected]>
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 28, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@atgeller