Skip to content

Conversation

bmhowe23
Copy link
Collaborator

@bmhowe23 bmhowe23 commented Aug 22, 2025

We may - from time to time - need to update our PyPI wheels' METADATA files without going through a full new release. The script in this PR will help that process.

@bmhowe23 bmhowe23 requested review from melody-ren and mitchdz August 22, 2025 21:36
Copy link
Collaborator

@melody-ren melody-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script works. Thanks.

Should the wheel names be changed to cudaq-qec/cudaq-solvers to match pypi though?

@bmhowe23
Copy link
Collaborator Author

Script works. Thanks.

Should the wheel names be changed to cudaq-qec/cudaq-solvers to match pypi though?

Do we have an example where the current names aren't working? I was thinking the only previous demonstration of failure was with optional dependency packages names.

In any case, I think the build process must be putting the underscores in the filenames. Our pyproject.toml file already has the dashes. (CUDA-Q has the same thing.)

@melody-ren
Copy link
Collaborator

Script works. Thanks.
Should the wheel names be changed to cudaq-qec/cudaq-solvers to match pypi though?

Do we have an example where the current names aren't working? I was thinking the only previous demonstration of failure was with optional dependency packages names.

In any case, I think the build process must be putting the underscores in the filenames. Our pyproject.toml file already has the dashes. (CUDA-Q has the same thing.)

Current names work. I just find it confusing, but maybe don't fix things that aren't broken

@bmhowe23
Copy link
Collaborator Author

Current names work. I just find it confusing, but maybe don't fix things that aren't broken

OK, good. I wouldn't even know where to change it to be honest. I think this might be a case of the Python spec dictating that because https://packaging.python.org/en/latest/specifications/binary-distribution-format/#binary-distribution-format says:

The wheel filename is {distribution}-{version}(-{build tag})?-{python tag}-{abi tag}-{platform tag}.whl.

So the - is the delimiter between sections in the filename, so the build system probably changes them to _ during the build.

@bmhowe23 bmhowe23 merged commit 4efa0d0 into NVIDIA:main Aug 22, 2025
13 checks passed
@bmhowe23 bmhowe23 deleted the pr-add-patch-wheel-script branch August 22, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants