Skip to content

Conversation

mrcjkb
Copy link
Member

@mrcjkb mrcjkb commented Jul 24, 2025

haskellPackages.xxhash-ffi (if the pkg-config flag is enabled) depends on libxxhash, which is packaged as xxHash in nixpkgs.

Note: The build is actually broken because it can't find pkg-config:

Error: Setup: The program 'pkg-config' version >=0.9.0 is required but it
could not be found

So this is probably not enough to unbreak the package, but I think it will be necessary.

@sternenseemann
Copy link
Member

So this is probably not enough to unbreak the package

It'll be enough. pkg-config is made available as soon as we have a dependency that needs to be discovered using pkg-config.

@mrcjkb mrcjkb force-pushed the mj/push-rnzloplwxxtz branch from beebd3e to 44306b4 Compare July 24, 2025 12:50
@sternenseemann sternenseemann merged commit 6e7491d into NixOS:master Jul 24, 2025
8 checks passed
@mrcjkb mrcjkb deleted the mj/push-rnzloplwxxtz branch July 24, 2025 13:42
@sternenseemann
Copy link
Member

Applied in nixpkgs as NixOS/nixpkgs@1f230cd. You may need to send a PR to haskell-updates to remove the broken flag from the affected packages.

@mrcjkb
Copy link
Member Author

mrcjkb commented Aug 11, 2025

Thanks for the heads-up 🙏
I guess it will be marked as unbroken with the next hackage-packages update?
If so, I'm in no rush. Otherwise, how do I remove the broken flag without updating all the packages? I'm assuming there's a maintainers script for that?

@sternenseemann
Copy link
Member

I expect someone will remove the stale broken flags semi-automatically this rotation, so you can probably just wait. Otherwise you'd remove the offending lines from configuration-hackage2nix/broken.yaml and run maintainers/scripts/haskell/regenerate-hackage-packages.sh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants