Skip to content

feat: use url parameters #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2025
Merged

feat: use url parameters #90

merged 3 commits into from
Jun 4, 2025

Conversation

sanjayankur31
Copy link
Contributor

Fixes #86

@sanjayankur31 sanjayankur31 added this to the v0.3 milestone May 21, 2025
@sanjayankur31 sanjayankur31 requested a review from mstimberg May 21, 2025 14:46
@sanjayankur31 sanjayankur31 added the T: enhancement New feature or request label May 21, 2025
mstimberg
mstimberg approved these changes Jun 4, 2025
View reviewed changes
Copy link
Collaborator

@mstimberg mstimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a small bug: the asynchronous loading of the button icons meant that they were not necessarily available when showing the details of a simulator. All looks good to me now 👍

@mstimberg mstimberg merged commit 989b49b into main Jun 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstimberg mstimberg mstimberg approved these changes

Assignees
No one assigned
Labels
T: enhancement New feature or request
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.

Complete URL parameterization
2 participants
@sanjayankur31 @mstimberg