Code hot reloading #2101
Draft
Code hot reloading #2101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
OpenDreamRuntime/DreamManager.cs
Outdated
|
|
||
| _compiledJson = json; | ||
| var rootPath = Path.GetFullPath(Path.GetDirectoryName(jsonPath)!); | ||
| var resources = _compiledJson.Resources ?? Array.Empty<string>(); |
Check notice
Code scanning / InspectCode
Use collection expression syntax Note
OpenDreamRuntime/DreamManager.cs
Outdated
| _objectTree.LoadJson(json); | ||
| DreamProcNative.SetupNativeProcs(_objectTree); | ||
|
|
||
| } |
Check warning
Code scanning / InspectCode
Incorrect blank lines: Incorrect number of blank lines near braces Warning
| requestHotReloadBytecode.RespondError(client, "No file provided for a hot reload"); | ||
| return; | ||
| } | ||
| _sawmill.Debug($"Debug adapter triggered bytecode hot reload for file {requestHotReloadBytecode.Arguments.FilePath}"); |
Check warning
Code scanning / InspectCode
Incorrect blank lines: Blank lines are missing elsewhere Warning
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the vscode extension to trigger recompile and reload object and proc defs
OpenDreamProject/vscode-opendream#20