Skip to content

Particles #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 56 commits into
base: master
Choose a base branch
from
Open

Particles #2219

wants to merge 56 commits into from

Conversation

amylizzle
Copy link
Collaborator

@amylizzle amylizzle commented Feb 18, 2025 •
edited
Loading

Done but requires tweaks to match behaviour perfectly.
Screencast from 2025-06-30 21-34-22.webm

Implements /atom/movable/particles, /particles, and /generator

Fixes #2143

#2194

@boring-cyborg boring-cyborg bot added Client Involves the OpenDream client Runtime Involves the OpenDream server/runtime labels Feb 18, 2025
@amylizzle amylizzle mentioned this pull request Feb 18, 2025
Open
@boring-cyborg boring-cyborg bot added the Compiler Involves the OpenDream compiler label Feb 18, 2025
@github-actions github-actions bot added size/XL and removed size/L labels Feb 18, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added size/XXL and removed size/XL labels Feb 20, 2025
@amylizzle amylizzle changed the title Particles: Part 2 Particles: OD side Jun 30, 2025
@amylizzle
Copy link
Collaborator Author

TODO: remove gooncode and sprites from this for license stuff

@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added size/XXL and removed size/XL labels Aug 20, 2025
@amylizzle amylizzle marked this pull request as ready for review August 20, 2025 15:39
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 20, 2025
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

InspectCode found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@amylizzle amylizzle changed the title Particles: OD side Particles Aug 20, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@wixoaGit
Copy link
Member

I haven't done a thorough look through the code yet, but I tried testing this by booting up Paradise and shooting a girder. This should create some particles, but it broke the renderer instead. Some planes stopped rendering and there were errors every frame.

@amylizzle
Copy link
Collaborator Author

Ah that's because I hadn't implemented the generator type and had it throw instead - my bad, I just need to figure out the math and implement

@amylizzle amylizzle requested a review from wixoaGit September 3, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wixoaGit wixoaGit Awaiting requested review from wixoaGit

Assignees
No one assigned
Labels
Client Involves the OpenDream client Compiler Involves the OpenDream compiler Runtime Involves the OpenDream server/runtime size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/particle is not implemented
2 participants
@amylizzle @wixoaGit