-
Notifications
You must be signed in to change notification settings - Fork 79
Prepare for next development iteration 21.4.0-SNAPSHOT #2322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 21.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the project's version to 21.4.0-SNAPSHOT across all modules and upgrades several core Opendaylight dependencies, preparing the codebase for the next development iteration. It also includes minor refactoring of nullability annotations and updates to documentation.
Highlights
- Project Version Update: The main project version and all sub-module versions have been incremented from 21.3.0-SNAPSHOT to 21.4.0-SNAPSHOT.
- Opendaylight Dependency Upgrades: Key Opendaylight components such as odlparent, mdsal-artifacts, yangtools-artifacts, and others have been updated to their latest patch versions, ensuring compatibility and leveraging recent fixes.
- Build Tooling Updates: Maven plugins for YANG compilation, code style checking (Checkstyle), and static analysis (SpotBugs) have been upgraded to align with the new Opendaylight parent versions.
- Nullability Annotation Refactoring: Imports for @nullable annotations in gNMI southbound modules have been migrated from checkerframework to eclipse.jdt.annotation for consistency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
991eca6
to
a265a67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request prepares the project for the next development iteration, 21.4.0-SNAPSHOT
. The changes primarily consist of version bumps across numerous pom.xml
files, updating the project version and its dependencies. Additionally, some README.md
files have been updated to reflect the new version in usage examples. There are also minor formatting changes in some XML files and a consistent use of @Nullable
annotations in Java files. My review focuses on some formatting changes in pom.xml
files that affect readability. Overall, the changes are consistent with the goal of preparing for a new development version.
<project xmlns="http://maven.apache.org/POM/4.0.0" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability, it's good practice to have each attribute of an XML tag on a new line, especially when there are multiple attributes. This makes the POM file easier to read and maintain.
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | |
<project xmlns="http://maven.apache.org/POM/4.0.0" | |
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> |
@@ -81,8 +79,7 @@ | |||
<phase>prepare-package</phase> | |||
<configuration> | |||
<target> | |||
<unzip src="${basedir}/../lighty-rcgnmi-app/target/${lighty.app.zip}" | |||
dest="${basedir}/target/docker-stage" /> | |||
<unzip src="${basedir}/../lighty-rcgnmi-app/target/${lighty.app.zip}" dest="${basedir}/target/docker-stage" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and maintainability, it's recommended to keep attributes of XML tags on separate lines, especially for long lines like this one. This makes the code easier to read and understand.
<unzip src="${basedir}/../lighty-rcgnmi-app/target/${lighty.app.zip}"
dest="${basedir}/target/docker-stage" />
@@ -78,8 +78,7 @@ | |||
<phase>prepare-package</phase> | |||
<configuration> | |||
<target> | |||
<unzip src="${basedir}/../lighty-rnc-app/target/${lighty.app.zip}" | |||
dest="${basedir}/target/docker-stage" /> | |||
<unzip src="${basedir}/../lighty-rnc-app/target/${lighty.app.zip}" dest="${basedir}/target/docker-stage" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and maintainability, it's recommended to keep attributes of XML tags on separate lines, especially for long lines like this one. This makes the code easier to read and understand.
<unzip src="${basedir}/../lighty-rnc-app/target/${lighty.app.zip}"
dest="${basedir}/target/docker-stage" />
JIRA: LIGHTY-368 Signed-off-by: tobias.pobocik <[email protected]>
JIRA: LIGHTY-368 Signed-off-by: tobias.pobocik <[email protected]>
JIRA: LIGHTY-368 Signed-off-by: tobias.pobocik <[email protected]>
JIRA: LIGHTY-368 Signed-off-by: tobias.pobocik <[email protected]>
a265a67
to
1cd5381
Compare
No description provided.