Skip to content

Conversation

Tobianas
Copy link
Contributor

No description provided.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Tobianas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily updates the project version from 21.3.0-SNAPSHOT to 21.4.0-SNAPSHOT across the entire codebase. This is a standard procedure to prepare the project for the next development cycle, rather than an actual release. It also includes updates to various Opendaylight-related dependencies and minor code formatting adjustments.

Highlights

  • Project Version Bump: The core project version has been incremented from 21.3.0-SNAPSHOT to 21.4.0-SNAPSHOT in all relevant pom.xml files.
  • Opendaylight Dependency Upgrades: Key Opendaylight artifacts such as odlparent, aaa-artifacts, controller-artifacts, infrautils-artifacts, mdsal-artifacts, netconf-artifacts, yangtools-artifacts, and bgpcep-artifacts have been updated to their latest patch versions.
  • Build Configuration Refinements: Minor formatting adjustments were made in the tasks within the lighty-rcgnmi-app-docker and lighty-rnc-app-docker Maven configurations.
  • Documentation Alignment: README.md files in example projects have been updated to reflect the new 21.4.0-SNAPSHOT version in their usage instructions.
  • Annotation Import Refactoring: The @nullable annotation import has been changed from org.checkerframework.checker.nullness.qual.Nullable to org.eclipse.jdt.annotation.Nullable in specific gNMI southbound listener and operation files.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be a standard version bump to prepare for the next development cycle, updating from 21.3.0-SNAPSHOT to 21.4.0-SNAPSHOT and refreshing dependencies. The changes are mostly mechanical and look correct. The pull request title, "Prepare release 21.3.0", is slightly misleading given the version bump to 21.4.0-SNAPSHOT, and might be clearer as "Prepare for 21.4.0 development". I've included a few minor suggestions to improve the formatting of some pom.xml files for better readability.

<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change combines multiple attributes of the <project> tag into a single line, which makes it very long and harder to read. For better readability and maintainability, it's preferable to keep attributes on separate lines.

Suggested change
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<project xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

@@ -81,8 +79,7 @@
<phase>prepare-package</phase>
<configuration>
<target>
<unzip src="${basedir}/../lighty-rcgnmi-app/target/${lighty.app.zip}"
dest="${basedir}/target/docker-stage" />
<unzip src="${basedir}/../lighty-rcgnmi-app/target/${lighty.app.zip}" dest="${basedir}/target/docker-stage" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change combines the attributes of the <unzip> tag into a single line, which makes it harder to read. For better readability, it's preferable to keep attributes on separate lines, especially when the line becomes long.

                                <unzip src="${basedir}/../lighty-rcgnmi-app/target/${lighty.app.zip}"
                                       dest="${basedir}/target/docker-stage" />

@@ -78,8 +78,7 @@
<phase>prepare-package</phase>
<configuration>
<target>
<unzip src="${basedir}/../lighty-rnc-app/target/${lighty.app.zip}"
dest="${basedir}/target/docker-stage" />
<unzip src="${basedir}/../lighty-rnc-app/target/${lighty.app.zip}" dest="${basedir}/target/docker-stage" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change combines the attributes of the <unzip> tag into a single line, which makes it harder to read. For better readability, it's preferable to keep attributes on separate lines, especially when the line becomes long.

                                <unzip src="${basedir}/../lighty-rnc-app/target/${lighty.app.zip}"
                                       dest="${basedir}/target/docker-stage" />

JIRA: LIGHTY-368
Signed-off-by: tobias.pobocik <[email protected]>
JIRA: LIGHTY-368
Signed-off-by: tobias.pobocik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant