Convert client.key to RSA format

[ihrasko]

GNMI app cannot read PEM encoded client key. Our only option is to use RSA encoding.

GH issue: #2355

[gemini-code-assist]

Summary of Changes

Hello @ihrasko, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical compatibility issue preventing the GNMI application from correctly processing client keys. By introducing an automated step within the certificate generation script to convert the client key to RSA format, the PR ensures seamless integration and functionality for the GNMI app.

Highlights

• Client Key Format Conversion: The client.key is now converted from PEM to RSA format to resolve compatibility issues with the GNMI application.
• GNMI App Compatibility: This change specifically addresses the limitation where the GNMI app was unable to read PEM encoded client keys, ensuring it can now properly utilize the key.
• Certificate Generation Script Update: The generate_certs.sh script has been updated to include the necessary openssl commands for the key format conversion.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the certificate generation script to convert the client.key to the traditional RSA format (PKCS#1), as required by the GNMI application. The change is functionally correct for its purpose, but the implementation for replacing the key file is not robust. I've provided a critical comment with a suggestion to prevent accidental deletion of the key file in case of an error during conversion.