Skip to content

Fix some issues with PlayerLeashEntityEvent #13015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix some issues with PlayerLeashEntityEvent #13015

wants to merge 4 commits into from

Conversation

Lulu13022002
Copy link
Contributor

  • a duplicate event when interact on an existing knot (reported in Improve APIs around riptide tridents #12996)
  • leashableInArea return an unmodifiable list, yet when the event is cancelled an element is removed, the new boolean should be enough to prevent the game event
  • only call the event if the entity can actually be tied

@Lulu13022002 Lulu13022002 requested a review from a team as a code owner August 24, 2025 16:16
@github-project-automation github-project-automation bot moved this to Awaiting review in Paper PR Queue Aug 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytv kennytv kennytv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Paper PR Queue
Status: Awaiting review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lulu13022002 @kennytv