Optimize setup flow for table addition #2141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
approved these changes
Oct 16, 2024
heavycrystal
approved these changes
Jun 11, 2025
serprex
reviewed
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the CreateNormalizedTable activity, we fetch the tablenameschemamapping from catalog and pass it to the setupNormalize function of the connector.
This does not make sense for table addition however, where setup flow needs to be done for a handful of tables and not the entire set
This PR refactors the activity to pass in the tables provided as input to the activity and uses the catalog map to get the source schema of the tables
Also rename a few symbols to be more readable