persist go module cache and build cache during local development #3045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oops, just realize this Dockerfile is shared in prod as well. probably want to separate out the base image for dev |
serprex
approved these changes
Jun 12, 2025
| @@ -17,7 +17,9 @@ RUN rm -f go.work* | |||
| # build the binary from flow folder | |||
| WORKDIR /root/flow | |||
| ENV CGO_ENABLED=1 | |||
| RUN go build -o /root/peer-flow | |||
| RUN --mount=type=cache,target=/go/pkg/mod \ | |||
| --mount=type=cache,target=/root/.cache/go-build \ | |||
There was a problem hiding this comment.
wouldn't this be dependent on many things like compiler version and flags? wondering if it's worth it
There was a problem hiding this comment.
this made a pretty big difference for me when tested ./dev-peerdb.sh locally:
- without it you get a cold build which is 200s+
- tested out switch between branches with this change and took 15-20s to build
I'll punt on merging this for now though -- want to separate out the mount logic to only local development. in prod we probably benefit from clean build in general -- but it speeds up docker builds for me when testing locally with this change.
| @@ -8,7 +8,7 @@ WORKDIR /root/flow | |||
| COPY flow/go.mod flow/go.sum ./ | |||
|
|
|||
| # download all the dependencies | |||
| RUN go mod download | |||
| RUN --mount=type=cache,target=/go/pkg/mod go mod download | |||
There was a problem hiding this comment.
iirc this wouldn't work for some reason, maybe things are better now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid re-downloading go modules from scratch every time. Also include build cache as well to speed up build.