Skip to content

Improve JoinData #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 8, 2020
Merged

Improve JoinData #2153

merged 2 commits into from
Jul 8, 2020

Conversation

ImMorpheus
Copy link
Contributor

Fix #1845

Offline players:

A joined  -> first joined
A left
A joined
A left
A joined  -> last joined
A left    -> last played

Online players:

A joined  -> first joined
A left
A joined
A left    -> last played
A joined  -> last joined

@ImMorpheus ImMorpheus added the api: 8 (u) version: 1.16 (unsupported since Oct 17th 2023) label Jul 4, 2020
@ImMorpheus ImMorpheus requested a review from gabizou as a code owner July 4, 2020 13:05
@ImMorpheus ImMorpheus linked an issue Jul 4, 2020 that may be closed by this pull request
Improve PlayerJoinData to support extra data. #1845
Closed
Zidane
Zidane reviewed Jul 4, 2020
View reviewed changes
src/main/java/org/spongepowered/api/data/Keys.java Outdated

/**
* The time a {@link Player} first played on the Server.
* The time a {@link Player} first joined on the Server.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{@link Player} -> {@link ServerPlayer player}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this should be a User

@Zidane Zidane merged commit 6aa99ec into SpongePowered:api-8 Jul 8, 2020
@ImMorpheus ImMorpheus deleted the fix/join-data branch July 8, 2020 18:36
This was referenced Jan 9, 2022
Closed
Closed
Closed
@renovate renovate bot mentioned this pull request Mar 4, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zidane Zidane Zidane left review comments

@gabizou gabizou Awaiting requested review from gabizou

Assignees
No one assigned
Labels
api: 8 (u) version: 1.16 (unsupported since Oct 17th 2023)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve PlayerJoinData to support extra data.
2 participants
@ImMorpheus @Zidane