-
-
Notifications
You must be signed in to change notification settings - Fork 341
Add ParticleOptions.SCALE back to the API #2330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* vanilla {@link ParticleType}s this option is applicable to is: | ||
* | ||
* <ul> | ||
* <li>{@link ParticleTypes#DUST}</li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've changed this documentation because dust is the only particle whose size can be changed with the /particle
command (MC 1.16). I'm not sure if there are other particles that can still have their size modified by packet options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wolfizen This looks good.
Can you add a default method to ParticleEffect.Builder
? See
SpongeAPI/src/main/java/org/spongepowered/api/effect/particle/ParticleEffect.java
Lines 160 to 194 in 32cad1a
* Sets the velocity of the particle effect. | |
* | |
* <p>The default velocity is {@link Vector3d#ZERO}.</p> | |
* | |
* @param velocity The velocity | |
* @return This builder for chaining | |
*/ | |
default Builder velocity(Vector3d velocity) { | |
return this.option(ParticleOptions.VELOCITY, velocity); | |
} | |
/** | |
* Sets the offset of the particle effect. | |
* | |
* <p>The default offset is {@link Vector3d#ZERO}.</p> | |
* | |
* @param offset The offset | |
* @return This builder for chaining | |
*/ | |
default Builder offset(Vector3d offset) { | |
return this.option(ParticleOptions.OFFSET, offset); | |
} | |
/** | |
* Sets the amount of particles of the particle effect. | |
* | |
* <p>The default quantity is 1.</p> | |
* | |
* @param quantity The quantity particles | |
* @return This builder, for chaining | |
* @throws IllegalArgumentException If the quantity is less than one | |
*/ | |
default Builder quantity(int quantity) throws IllegalArgumentException { | |
return this.option(ParticleOptions.QUANTITY, quantity); | |
} |
@ImMorpheus Done and re-tested. :) |
This particle type was commented out, I implemented this option in SpongePowered/Sponge#3368 so this PR adds the option back to the API.