refactor ui tests #1148
Merged
refactor ui tests #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-magda
requested changes
May 26, 2022
There was a problem hiding this comment.
Ты не против, если бы я сделал shared файл между приложением и UI тестами, где были бы описаны все константы accessibility идентификаторов. Кажется так будет меньше шанс ошибиться и нужно будет указать строку идентификатора только в одном месте. Пример как будет выглядеть использование такого API:
в приложении
self.actionButton.accessibilityIdentifier = AccessibilityIdentifiers.loginButtonв UI тестах
app.buttons[AccessibilityIdentifiers.loginButton]Ещё у нас имеется линтер и автоматические исправления в соответствии code style.
- Запусти автоматические исправления в командной строке
./autocorrect.sh StepicUITests - Запусти линтер, чтобы увидеть замечания в командной строке
./lint.sh StepicUITests. Если не удастся исправить все замечания, то я пофиксю. - Ознакомься с Code Style Stepik.
Stepic/Legacy/Controllers/Onboarding/OnboardingPageView/OnboardingPageView.xib
Outdated
Show resolved
Hide resolved
ivan-magda
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
@annafalileeva все ОК 👍
Я еще немножко причесал тесты c17d9e6 и весь код поместил в папку Sources.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTrack task: #APPS-3640
Description:
refactor ui tests