Achievements #303
Merged
Achievements #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ostrenkiy
suggested changes
Jun 18, 2018
Stepic/AchievementDescription.swift
Outdated
| import Foundation | ||
|
|
||
| enum AchievementKind: String { | ||
| // Cases should be declared in correct order |
There was a problem hiding this comment.
А что от этого зависит сейчас?
| import PromiseKit | ||
| import Alamofire | ||
|
|
||
| enum ApiOrder { |
There was a problem hiding this comment.
Если планируется это использовать еще где-то, то можно вынести наверное куда-нибудь в отдельное место
|
|
||
| override func viewWillAppear(_ animated: Bool) { | ||
| super.viewWillAppear(animated) | ||
| view.showAnimatedGradientSkeleton(usingGradient: SkeletonGradient(baseColor: UIColor.mainLight), |
There was a problem hiding this comment.
возможно ли это делать по viewDidLoad?
сейчас если легонько свайпнуть влево экран (на предыдущий), а потом вернуться на экран с ачивками, все зависает на скелетоне.
| private var achievementsStackView: UIStackView? | ||
| private var isSet = false | ||
|
|
||
| // FIXME: check screen resolution |
There was a problem hiding this comment.
думаешь, для планшетов надо больше показывать?
Stepic/ru.lproj/Localizable.strings
Outdated
| AchievementsStepsSolvedStreakKindTitle = "Сапёр"; | ||
| AchievementsActiveDaysStreakKindTitle = "Постоянный пользователь"; | ||
| AchievementsLockedTitle = "Вау, что это?"; | ||
| AchievementsLockedDescription = "Решайте больше заданий, чтобы открыть"; |
There was a problem hiding this comment.
Российских локализаций больше, чем английских.
Не хватает английских описаний для ачивок.
| if let userId = self?.otherUserId ?? AuthInfo.shared.userId, | ||
| let vc = ControllerHelper.instantiateViewController(identifier: "AchievementsListViewController", storyboardName: "Profile") as? AchievementsListViewController { | ||
| // FIXME: API injection :(( | ||
| let retriever = AchievementsRetriever(userId: userId, achievementsAPI: AchievementsAPI(), achievementProgressesAPI: AchievementProgressesAPI()) |
There was a problem hiding this comment.
ну, лучше не очень ясно как сделать :(
…tepik-ios into feature/achievements
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача: #APPS-1893
Коротко для Release Notes, в формате «Сделали/Добавили/Исправили N»:
Добавили достижения
Описание:
Достижения в профиле.
TODO