Skip to content

Conversation

ivan-magda
Copy link
Member

@ivan-magda ivan-magda commented Aug 7, 2019

Release 1.89 milestone

Main & Common

  • Code quiz & fullscreen #493
  • Pluralize achievements #501
  • Rename personal deadlines select time title #502
  • Hide video player controls automatically #503
  • Show certificates in profile #504
  • Lesson info tooltip #507
  • Handle certificates deep link #507

* Pluralize achievements descriptions
* Remove checks for tvOS

* Remove empty group

* Format code

* Remove Certificates from tab bar

* Update positions

* Display certificates in profile menu

* Display certificates of the different users

* Update empty certificates state placeholders

* Create CertificatesLegacyAssembly

* Dispalay loading firstly

* Add is_organization field

* Hide certificates for organizations
* Create NewCodeQuiz module

* Remove unused

* Initial for CodeTextView

* Fix swiftlint messages

* Remove unused infoBarButtonItem

* Remove unused tooltipView property

* Update request body logging

* Fix typo

* Sort BaseQuiz's files by name and type

* Refactor rename group Child protocols -> ChildProtocols

* Clean up

* Fix typo

* Add TODO

* Use optional string interpolation operator

* Sort quiz groups

* Update comment

* Refactor rename separatorWidth -> separatorHeight

* Fix set translatesAutoresizingMaskIntoConstraints to false

* Refactor rename separatorWidth -> separatorHeight

* Conform NewCodeQuizAssembly to QuizAssembly

* Conform CodeLanguage to CaseIterable

* Sort quizzes group

* Remove checks for os(tvOS)

* Add description properties

* Create NewCodeQuizViewModel

* Init CodeReply with code and languageName

* Init for present & update reply

* Provide step options

* Display code details

* Rotate arrow image on click

* Remove todo

* Refactor rename

* Language picker header

* Language picker select language

* Conform to NewCodeQuizViewDelegate

* Refactor rename

* Persist execution_time_limit and execution_memory_limit

* Multy line code sample and monospace font

* Update data flow

* Add final state

* Render code toolbar

* Add default state

* Show code text view

* Select language on state noLanguage

* Add newCodeQuizViewDidRequestFullscreen(_:)

* Fix set language firstly

* Handle language selection on toolbar

* Enable or disable controls based on current status

* tmp

* Fix issues with ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES

* Setup theme

* Update code reply on text change

* Update SeparatorView appearance

* Use SeparatorView

* Animate code details content alpha component

* Use SeparatorView

* Output current code reply on language select

* Update appearance of code editor

* Fix language chosen analytics param name

* Auto select language if one

* Do not clear current code and language on reply update

* Disable code text view auto correction features

* Refactor rename notSupportedLanguage -> unsupportedLanguage

* Handle empty state for code language picker

* Handle unsupported code language

* Update Podfile.lock

* Code completion and suggestions

* Use partial from operator

* Rearrange code

* Fix toolbar collapse after language picked

* tmp

* Update visibility flow

* Remove unused

* Select code suggestion if text view editable

* Make setupAccessoryView(isEditable:) private

* Display language name inside of code editor

* Provide step text content

* Display fullscreen

* Display tabs

* Fix index out of bounds

* tmp

* Set backgroundColor

* Create CodeEditorSettingsLegacyAssembly

* Add todo's

* Remove unused

* Update todo with lesson title

* Create StepOptionsPersistenceService

* StepOptions to plain object

* Initial for NewCodeQuizProvider

* Create CodeDetails

* Update child quiz input with code details

* Use code details

* Refactor rename

* Refactor rename codeLanguage -> language

* Update presenter

* Create code editor theme service

* Update fullscreen

* Use plain objects

* Set title for fullscreen

* Update & submit reply

* Refactor rename SomeAction to ContentLoad

* Auto update code editor theme

* Refactor rename

* reset

* Update default code editor theme

* Delete after merge

* Undo changes for NewLessonViewController

* Move down

* Set space between pages

* Add Swift support
* Update code language name visibility for fullscreen

* Fix language name label top offset
* Add icons

* Present dummy tooltip on info button click

* Add localizable

* Pluralize points via Formatterhelper

* Configure tooltip with data

* Update load

* Update on step done

* Use FormatterHelper.pointsCount

* Check for empty info
* route to certificates deep link
* Fix code with code reset on tab scroll

* Retry code quiz without new attempt
Manually call textViewDidChange, becuase when manually setting the text of a UITextView with code, the textViewDidChange: method does not get called.
@ivan-magda ivan-magda merged commit 08e7013 into master Aug 10, 2019
@ivan-magda ivan-magda deleted the release/1.89 branch August 10, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant