Add input shapes validation #6218
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The binary size change of libncnn.so (bytes)
|
Deepdive543443
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6218 +/- ##
==========================================
+ Coverage 95.85% 95.89% +0.03%
==========================================
Files 840 840
Lines 265625 265631 +6
==========================================
+ Hits 254628 254737 +109
+ Misses 10997 10894 -103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nihui
requested changes
Sep 12, 2025
src/net.cpp
Outdated
Comment on lines
2209
to
2212
| Mat shape = d->net->blobs()[blob_index].shape; | ||
| if (shape.total() && (shape.w != in.w) && (shape.h != in.h) && (shape.d != in.d) && (shape.c != in.c)) | ||
| return -1; | ||
|
|
There was a problem hiding this comment.
- 这地方是不是得 || 而不是 &&
- shape 总是 pack1 的，而 in 可能是任意 pack，要考虑有 pack 的情形
- shape 中可能存在 w h d c <=0 的情形，表示动态，要考虑这种情形
nihui
requested changes
Sep 13, 2025
Deepdive543443
force-pushed
the
patch
branch
from
b3df081 to
614eaca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.