Skip to content

Fix bugs that exceed boundaries when selecting text. (Issue: #88) #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix bugs that exceed boundaries when selecting text. (Issue: #88) #90

wants to merge 3 commits into from

Conversation

YowFung
Copy link

@YowFung YowFung commented Feb 18, 2022

Fix the bug according to #88.

devmil
devmil requested changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@devmil devmil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this issue!
I think you should remove the selection clearance and copy to clipboard on mouse click behavior and make a separate PR with it
I think having this in the example is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmil devmil devmil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YowFung @devmil