Skip to content

Conversation

Akshat1931
Copy link

Please review the following checklist.

  • [ x ] Docstrings on all new or modified functions / classes
  • [ x ] Updated documentation
  • [ x ] Updated CHANGELOG.md (where appropriate)

Note: This is a minimal 1-line fix to a visual alignment issue. No new functions, behavior, or user-facing changes were introduced — so docstrings, docs, and CHANGELOG updates are not applicable.

@TomJGooding
Copy link
Collaborator

Can you explain what issue this fixes? Because this looks like you've just added a random test file.

@Akshat1931
Copy link
Author

issue no 6103 there was mis alignment of title

@TomJGooding
Copy link
Collaborator

Let me try asking another way: how do you think adding your_test_file.py will change anything in the Textual library?

@Akshat1931
Copy link
Author

i think one of the file didnt get commited accidently let me me check sorry for the trouble

@Akshat1931
Copy link
Author

The accidental test file has been removed — the PR now only contains the fix for the header title alignment (issue #6103).

Copy link
Member

@willmcgugan willmcgugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need a snapshot test for this.

pyproject.toml Outdated
@@ -44,7 +44,7 @@ include = [
target-version = "py38"

[tool.poetry.dependencies]
python = "^3.8.1"
python = ">=3.10,<4.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any need to change the Python version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the Python version temporarily on my local setup so I could run the project, because it wasn’t working with my environment. I understand that this change isn’t needed for the project itself, so I can revert it if you prefer.

Copy link
Collaborator

@TomJGooding TomJGooding Sep 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to revert pyproject.toml to exactly as it was before. If you check the 'Files Changed' tab in this PR you'll see there's still 2 files changed.

Hopefully you already did read the contributing guide, but that explains how to add a snapshot test for your changes.

@willmcgugan
Copy link
Member

Are you using AI for this? Your snapshot test suggests you haven't looked at existing snapshot tests.

@Akshat1931 Akshat1931 closed this Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants