-
-
Notifications
You must be signed in to change notification settings - Fork 974
header_allignment_fixed #6113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
header_allignment_fixed #6113
Conversation
Can you explain what issue this fixes? Because this looks like you've just added a random test file. |
issue no 6103 there was mis alignment of title |
Let me try asking another way: how do you think adding |
i think one of the file didnt get commited accidently let me me check sorry for the trouble |
The accidental test file has been removed — the PR now only contains the fix for the header title alignment (issue #6103). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need a snapshot test for this.
pyproject.toml
Outdated
@@ -44,7 +44,7 @@ include = [ | |||
target-version = "py38" | |||
|
|||
[tool.poetry.dependencies] | |||
python = "^3.8.1" | |||
python = ">=3.10,<4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any need to change the Python version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the Python version temporarily on my local setup so I could run the project, because it wasn’t working with my environment. I understand that this change isn’t needed for the project itself, so I can revert it if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to revert pyproject.toml
to exactly as it was before. If you check the 'Files Changed' tab in this PR you'll see there's still 2 files changed.
Hopefully you already did read the contributing guide, but that explains how to add a snapshot test for your changes.
Are you using AI for this? Your snapshot test suggests you haven't looked at existing snapshot tests. |
Please review the following checklist.
Note: This is a minimal 1-line fix to a visual alignment issue. No new functions, behavior, or user-facing changes were introduced — so docstrings, docs, and CHANGELOG updates are not applicable.