Remove filestore APIs and libmagic dependency. #5601
+2
−3,594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
added a commit
that referenced
this pull request
Aug 5, 2025
As a stopgap before #5601, this PR updates the filestore APIs to remove the content sniffing features that depended on libmagic, and consequently, removes the Core's dependency to libmagic. --- TYPE: BREAKING_BEHAVIOR DESC: `tiledb_filestore_uri_import` and `tiledb_filestore_buffer_import` no longer auto-detect the file's MIME type. `TILEDB_MIME_AUTODETECT` will always set the filestore array's MIME type to `application/octet-stream`. --- TYPE: BREAKING_BEHAVIOR DESC: `tiledb_filestore_uri_import` and `tiledb_filestore_buffer_import` no longer auto-detect the file's encoding. New filestore arrays will always have their encoding metadata set to `binary`. --- TYPE: BREAKING_BEHAVIOR DESC: `tiledb_filestore_uri_import` and `tiledb_filestore_buffer_import` no longer compresses the filestore array's content. --- TYPE: BUILD DESC: Removed dependency to libmagic.
|
Should we close this for now? |
|
We can, but keeping it open doesn't hurt either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent with our API deprecation policy, this PR removes the
tiledb_filestoreAPIs, which were deprecated in version 2.27.0.TYPE: BREAKING_API
DESC: Removed
tiledb_filestoreAPIs.