Add support for grids when surface is LCL #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbruick
added
Area: Calc
|
Updated the docstring. Doesn't look like LGTM is working right, but everything else passed. |
zbruick
force-pushed
the
lcl_probs
branch
2 times, most recently
from
f669d50 to
c70ee01
Compare
dopplershift
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Adjusts the use of
np.iscloseto support grids, as arrays can be passed tolcland it will return arrays. This may solve #1199, depending on what others want from there. This preserves functionality without clarifying docstrings at all. That could be added to this PR as well.Checklist
-->