Skip to content

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Aug 18, 2025

High Level Overview of Change

This PR adds transaction formats, ledger entry formats, and transaction flags to server_definitions.

TODO: ledger entry flags

Context of Change

Alternative to #5616
Closes #5151

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Test Plan

TODO, waiting for feedback on the format before putting in that effort

@mvadari mvadari added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Aug 18, 2025
@mvadari mvadari force-pushed the server_definitions2 branch from 0e8fb16 to fa0d5a6 Compare August 22, 2025 17:37
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

❌ Patch coverage is 98.30508% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.7%. Comparing base (7775c72) to head (85b015b).

Files with missing lines Patch % Lines
src/xrpld/rpc/handlers/ServerDefinitions.cpp 98.2% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5702   +/-   ##
=======================================
  Coverage     78.7%   78.7%           
=======================================
  Files          814     815    +1     
  Lines        71680   71740   +60     
  Branches      8445    8444    -1     
=======================================
+ Hits         56396   56460   +64     
+ Misses       15284   15280    -4     
Files with missing lines Coverage Δ
src/libxrpl/protocol/LedgerFormats.cpp 100.0% <100.0%> (ø)
src/libxrpl/protocol/TxFormats.cpp 100.0% <100.0%> (ø)
src/xrpld/app/tx/detail/AMMDeposit.cpp 96.4% <100.0%> (ø)
src/xrpld/app/tx/detail/AMMWithdraw.cpp 95.2% <100.0%> (ø)
src/xrpld/app/tx/detail/Clawback.cpp 98.3% <100.0%> (ø)
src/xrpld/app/tx/detail/MPTokenIssuanceDestroy.cpp 90.0% <100.0%> (ø)
src/xrpld/app/tx/detail/NFTokenAcceptOffer.cpp 92.1% <100.0%> (ø)
src/xrpld/app/tx/detail/NFTokenCancelOffer.cpp 93.5% <100.0%> (ø)
src/xrpld/app/tx/detail/NFTokenMint.cpp 97.4% <100.0%> (ø)
src/xrpld/app/tx/detail/PayChan.cpp 90.5% <100.0%> (ø)
... and 3 more

... and 3 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DraftRunCI Normally CI does not run on draft PRs. This opts in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add transaction and ledger entry formats to server_definitions
1 participant