-
Notifications
You must be signed in to change notification settings - Fork 523
Closed
Labels
P3When you get around it. E.g. a fix for non-breaking issue we will work on when there's nothing moreWhen you get around it. E.g. a fix for non-breaking issue we will work on when there's nothing morefalse negativesselectedThe issue has been selected to be worked on.The issue has been selected to be worked on.
Description
Hello,
The following filter creates a FN for us:
return re.compile(r'(^(id|myid|userid)|_id)s?[^a-z0-9]', re.IGNORECASE) |
The scanned secret we have in Dockerfile:
ENV aws_access_key_id=AKIA4NACSIJMDDNSEDTE
The secret itself would correctly trigger the aws plugin but the is_likely_id_string causes it to be missed.
Perhaps at least some of the filters should be applied only in case a regex based detector hasn't detected a secret.
Otherwise, pretty obvious cases can be missed only because of the secret name.
Metadata
Metadata
Assignees
Labels
P3When you get around it. E.g. a fix for non-breaking issue we will work on when there's nothing moreWhen you get around it. E.g. a fix for non-breaking issue we will work on when there's nothing morefalse negativesselectedThe issue has been selected to be worked on.The issue has been selected to be worked on.