-
Notifications
You must be signed in to change notification settings - Fork 523
Don't use Ansi Colors if not supported. #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
03d7300
Don't use Ansi Colors if not supported.
DW-Ernest 6a5576b
Add test coverage for utils/color
DW-Ernest e13e5aa
Rename util.color.supports_ansi_colors
DW-Ernest 41ce349
Rename color_test functions to better describe what the test is doing
DW-Ernest File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
from sys import stdout | ||
|
||
from detect_secrets.util.color import AnsiColor | ||
from detect_secrets.util.color import colorize | ||
|
||
|
||
def colorize_enabled(text: str, color: AnsiColor) -> str: | ||
return '\x1b{}{}\x1b{}'.format( | ||
color.value, | ||
text, | ||
AnsiColor.RESET.value, | ||
) | ||
|
||
|
||
def expect_enabled(text: str): | ||
for color in AnsiColor: | ||
expected = colorize_enabled(text, color) | ||
assert colorize(text, color) == expected | ||
|
||
|
||
def expect_disabled(text: str): | ||
for color in AnsiColor: | ||
assert colorize(text, color) == text | ||
|
||
|
||
def test_colorize_1(monkeypatch): | ||
monkeypatch.setenv('CLICOLOR', '1') | ||
|
||
if stdout.isatty(): | ||
expect_enabled('abc') | ||
else: | ||
expect_disabled('abc') | ||
|
||
|
||
def test_colorize_2(monkeypatch): | ||
DW-Ernest marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
monkeypatch.setenv('CLICOLOR_FORCE', '1') | ||
|
||
expect_enabled('abc') | ||
|
||
|
||
def test_colorize_3(monkeypatch): | ||
DW-Ernest marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
monkeypatch.setenv('CLICOLOR', '0') | ||
|
||
expect_disabled('abc') |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.