fix: removed code that caused claude send all mcp tool args as required #4453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Claude models were incorrectly marking all optional MCP tool parameters as required,
causing validation errors when Claude generated invalid default values in the args
Solution
Removed the faulty auto-requirement logic in
format_tools_for_model()
function inagno/utils/models/claude.py
that was making all non-nullable parameters required when noexplicit required parameters existed.
Changes
agno/utils/models/claude.py
Testing
Type of change
Checklist
./scripts/format.sh
and./scripts/validate.sh
)