Skip to content

Conversation

qichen012
Copy link

@qichen012 qichen012 commented May 20, 2025

Hi everyone,
This is my first Pull Request, and I'm a sophomore in Beijing University of Posts and Telecommunications,I'm still learning a lot , but I'm excited to contribute to this project, maybe there will be some problems, following is what I had done as the suggestions given by this table:

Describe what this PR does / why we need it

This PR simplifies the integration configuration of Spring Cloud Alibaba with Seata by removing redundant YAML properties, leveraging default conventions and global Nacos settings.

Does this pull request fix one issue?

No directly related issue (NONE). The goal is to reduce configuration redundancy and improve maintainability.

Fixes #3756

Describe how you did it

Removed duplicate configs: Eliminated redundant properties in seata.config and seata.registry that overlap with global Nacos settings.
Leveraged defaults: Relied on Seata’s default behaviors (e.g., auto-generated transaction group names, seata-server service discovery).
Kept critical configs: Only retained seata.enabled=true to ensure functionality.

Describe how to verify it

Start dependencies: Ensure Nacos and Seata Server are running.
Test transactions: Invoke a method annotated with @GlobalTransactional to verify distributed transactions.
Log inspection: Check Seata client/server logs for errors related to missing configurations.

Special notes for reviews

Version compatibility: Confirm compatibility between Spring Cloud Alibaba and Seata (e.g., 2021.0.x + Seata 1.5.x).
Custom needs: Explicit configurations are required if using non-default DataId or service names.

Thanks for your time and support !

Best regards,
qichen012

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


wemjie xiao seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@qichen012 qichen012 changed the title 文档:修复错别 通过设置默认属性来简化yml配置来删除冗余配置项目 May 20, 2025
@qichen012
Copy link
Author

Hello ? Maybe there is something wrong ?? I had signed this CLA
截屏2025-05-24 15 38 30

@qichen012
Copy link
Author

Hi @CLAassistant

I've signed the CLA (
截屏2025-05-24 15 38 30
), but the check is still showing as "pending". Could you help check if there's a sync issue?

Details:

Thanks for your help!

@yuluo-yx
Copy link
Collaborator

yuluo-yx commented Jul 3, 2025

commit 中和你本地的邮箱不同,可以检查下看看

Copy link
Collaborator

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Optimize] Optimizing autoconfiguration properties in seata
3 participants