Skip to content

Conversation

gregoire-dl
Copy link
Member

@gregoire-dl gregoire-dl commented Jul 28, 2025

Description

Various improvements / small fixes for the PhongImageViewer.

Features list

  • Remove Qt5Compat in DirectionalLightPane component.
  • Use qml Loader in Viewer2D for PhongImageViewerToolbar and DirectionalLightPane components.
  • Allow PhongImageViewer to read droped pictures.
  • Fix loading status and display image error info pane.

Implementation remarks

Linked to QtAliceVision PR: alicevision/QtAliceVision#89

@gregoire-dl gregoire-dl added this to the Meshroom 2025.x milestone Jul 28, 2025
@gregoire-dl gregoire-dl self-assigned this Jul 28, 2025
@gregoire-dl gregoire-dl added type:enhancement wip work in progress labels Jul 28, 2025
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.52%. Comparing base (8ffc283) to head (c9f0285).
⚠️ Report is 7 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2781   +/-   ##
========================================
  Coverage    79.52%   79.52%           
========================================
  Files           51       51           
  Lines         6975     6975           
========================================
  Hits          5547     5547           
  Misses        1428     1428           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cbentejac cbentejac force-pushed the dev/phongImageViewerFixes branch from 99ea263 to c9f0285 Compare September 25, 2025 14:29
@cbentejac cbentejac merged commit ecff89a into develop Sep 25, 2025
5 checks passed
@cbentejac cbentejac deleted the dev/phongImageViewerFixes branch September 25, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants