Fix #157: Correct single quote escaping for POSIX shells #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed an issue with `run_command("echo 'Hello'")` where wrapping commands
in args in single quotes caused invalid parsing in POSIX-compliant shells.
In these shells, single quotes enclose literal text, making escape sequences
like `\'` invalid. For more details, refer to the GNU Bash manual:
https://www.gnu.org/software/bash/manual/html_node/Single-Quotes.html.
For example, calling `run_command("echo 'Hello'")` would be incorrectly
escaped by `vim.fn.shellescape` as `echo '\''Hello'\''`, leading to
invalid parsing. The fix replaces the outer double quotes with single
quotes where necessary and command arg with double qoute, ensuring proper
escaping and compatibility across different shell environments.
Signed-off-by: Daniel Temiagin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue with
run_command("echo 'Hello'")where wrapping commands in args in single quotes caused invalid parsing in POSIX-compliant shells. In these shells, single quotes enclose literal text, making escape sequences like\'invalid. For more details, refer to the GNU Bash manual: https://www.gnu.org/software/bash/manual/html_node/Single-Quotes.html.For example, calling
run_command("echo 'Hello'")would be incorrectly escaped byvim.fn.shellescapeasecho '\''Hello'\'', leading to invalid parsing. The fix replaces the outer double quotes with single quotes where necessary and command arg with double qoute, ensuring proper escaping and compatibility across different shell environments.