withResource

[rainerhahnekamp]

No description provided.

[michael-small]

Immediate round of things I noticed, will do at least one more at a deeper level in a bit

[michael-small]

This meant to be moved down to the types?

[michael-small]

As an rxResource enthusiast, I would like at least one test that has it, even though I know this is generic to any valid resource type. Even if it was just a cheap copy of an existing one, like this:

edit: done

        it('can accept an rxResource', async () => {
          const UserStore = signalStore(
            { providedIn: 'root' },
            withState({ userId: 1 }),
            withResource((store) =>
              rxResource({
                params: store.userId,
                stream: ({ params: id }) => of(id + 1),
              }),
            ),
          );

          const userStore = TestBed.inject(UserStore);

          await wait();
          expect(userStore.value()).toBe(2);
        });

[michael-small]

Oh, I pulled down your fork and tried to push up that commit fb77141 and assumed it would just open a PR to your fork. Oops, I didn't realize I could write directly to your fork's branch. Hope that change is good, I'll be careful next time knowing that.

[michael-small]

Two things and it's good

• Verify that the change I accidentally committed directly to this is good with you (build and test are fine)
• Please add something like that one rxResource test example somewhere, if not literally just that example. I suppose if you didn't mind I could just push it up too, apparently.

Otherwise, between this time and the times I have looked at the draft PR in the other repo, looks good to me.