Fix websocket relay. Set autocommit so conn.notifies() does not blocks forever #15043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fosterseth
approved these changes
Mar 27, 2024
|
fixes #15038 |
TheRealHaoLiu
changed the title
11 tasks
TheRealHaoLiu
changed the title
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
…s forever (ansible#15043) Without autocommit conn.notifies() blocks forever
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Nov 11, 2024
…s forever (ansible#15043) Without autocommit conn.notifies() blocks forever
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Jul 22, 2025
…s forever (ansible#15043) (ansible#6588) Without autocommit conn.notifies() blocks forever Co-authored-by: Chris Meyers <[email protected]>
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Jul 22, 2025
* Revert "[Backport][4.5] Fix wsrelay connection leak (ansible#6589)" This reverts commit 090350d. * Revert "Fix websocket relay. Set autocommit so conn.notifies() does not blocks forever (ansible#15043) (ansible#6588)" This reverts commit 3f3b764. * Revert "[4.5][backport] Fix wsrelay FATAL and not responsive after db disconnect (ansible#6584)" This reverts commit 5c87889. * Allow wsrelay to crash and prevent FATAL - sleep before crashing to prevent rapid restart - log after sleep because logging require DB connection and that can potentially cause another unhandled exception - lower startsec for wsrelay to 1 (default) to prevent FATAL * Backport ansible#14879
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix websocket relay.
Fixes #15038
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION