refactor: snapline and brush-select keep lineWidth after canvas zoom #6198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Aarebecca
commented
Aug 20, 2024
Aarebecca
commented
- The lineWidth of snapline and box of brush-select won't affected by canvas zoom
- Fix trigger brush select, 'Shift' + 'drag' operation won't trigger 'drag'
yvonneyx
approved these changes
Aug 20, 2024
|
brush select by drag (with no shortcut key) is not working after this patch. example: https://g6-next.antv.antgroup.com/examples/behavior/select#brush |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.