refactor(elements): move context from style to config #6525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Aarebecca
commented
Nov 15, 2024
Aarebecca
commented
- 元素 context 从 config 传入，而非 style。避免序列化元素 attributes 时出现循环引用问题
- The element context is passed in from the config instead of the style. To avoid circular reference issues when serializing element attributes.
Aarebecca
force-pushed
the
refactor/elements-context
branch
2 times, most recently
from
1385315 to
05da818
Compare
yvonneyx
reviewed
Nov 15, 2024
yvonneyx
approved these changes
Nov 15, 2024
Aarebecca
force-pushed
the
refactor/elements-context
branch
from
05da818 to
8cc7f2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.