Skip to content

Conversation

lewiszlw
Copy link
Member

Which issue does this PR close?

Closes #NNN.

Rationale for this change

Improve empty batches format.

What changes are included in this PR?

Add new pretty_format_batches_with_schema function.

Are there any user-facing changes?

Yes.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 11, 2025
@lewiszlw lewiszlw marked this pull request as draft June 11, 2025 08:31
@lewiszlw lewiszlw marked this pull request as ready for review June 11, 2025 08:57
@lewiszlw
Copy link
Member Author

Look like ci failure not caused by this pr.

@alamb
Copy link
Contributor

alamb commented Jun 12, 2025

Look like ci failure not caused by this pr.

I think it was fixed by @adamreeve yesterday in

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me -- thank you @lewiszlw

///
/// Useful to display empty batches.
///
/// # Example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the example!

@alamb
Copy link
Contributor

alamb commented Jun 12, 2025

I merged up from main to get the fix for the MIRI test and hopefully get a clean CI run

@alamb alamb merged commit c87a4d9 into apache:main Jun 13, 2025
26 checks passed
@alamb
Copy link
Contributor

alamb commented Jun 13, 2025

Thanks again @lewiszlw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants