Skip to content

[fix](binlog) Fix add partition record sql #35461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2024
Merged

[fix](binlog) Fix add partition record sql #35461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions fe/fe-core/src/main/java/org/apache/doris/binlog/AddPartitionRecord.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import org.apache.doris.catalog.Partition;
import org.apache.doris.catalog.PartitionItem;
import org.apache.doris.catalog.PartitionKey;
import org.apache.doris.catalog.RangePartitionItem;
import org.apache.doris.catalog.ReplicaAllocation;
import org.apache.doris.persist.PartitionPersistInfo;
import org.apache.doris.persist.gson.GsonUtils;
Expand Down Expand Up @@ -69,23 +70,34 @@ public AddPartitionRecord(long commitSeq, PartitionPersistInfo partitionPersistI
this.isMutable = partitionPersistInfo.isMutable();

StringBuilder sb = new StringBuilder();
sb.append("ADD PARTITION ").append("`").append(partition.getName()).append("`").append(" VALUES ");
if (this.listPartitionItem.equals(ListPartitionItem.DUMMY_ITEM)) {
sb.append("ADD ");
if (isTempPartition) {
sb.append("TEMPORARY ");
}
sb.append("PARTITION `");
sb.append(partition.getName());
sb.append("` ");

// See fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:addPartition for details.
if (!this.range.equals(RangePartitionItem.DUMMY_ITEM)) {
// range
sb.append("[");
sb.append("VALUES [");
sb.append(range.lowerEndpoint().toSql());
sb.append(", ");
sb.append(range.upperEndpoint().toSql());
sb.append(")");
} else {
sb.append(") (\"version_info\" = \"");
sb.append(partition.getVisibleVersion());
sb.append("\");");
} else if (!this.listPartitionItem.equals(ListPartitionItem.DUMMY_ITEM)) {
// list
sb.append("IN (");
sb.append("VALUES IN ");
sb.append(((ListPartitionItem) listPartitionItem).toSql());
sb.append(")");
sb.append(" (\"version_info\" = \"");
sb.append(partition.getVisibleVersion());
sb.append("\");");
} else {
// unpartitioned.
}
sb.append("(\"version_info\" = \"");
sb.append(partition.getVisibleVersion()).append("\"");
sb.append(");");
this.sql = sb.toString();
}

Expand Down